Re: [Buildroot] [PATCH v3 1/2] package/mpd: use upstream mpd.conf w/ buildroot modifications

[Andreas Ziegler <br025@umbiko.net>]

Ji Thomas,

On 2026-08-27 05:40, Thomas Petazzoni wrote:
> Hello Andreas,
> 
> On Thu, Aug 27, 2026 at 05:26:38AM +0200, Andreas Ziegler wrote:
>> +# sed snippet from https://stackoverflow.com/a/37911473
>> +# single-line configurations will be inserted behind the last 
>> matching line
>> +# in the target file, multi-line blocks are just appended at the 
>> bottom.
>>  define MPD_INSTALL_EXTRA_FILES
>> -	$(INSTALL) -m 0644 -D package/mpd/mpd.conf 
>> $(TARGET_DIR)/etc/mpd.conf
>> +	$(INSTALL) -m 0644 -D $(@D)/doc/mpdconf.example 
>> $(TARGET_DIR)/etc/mpd.conf
>> +	export multiline=0
>> +	while read -r line; do \
>> +		if [[ $$line =~ ^[a-zA-Z] ]]; then \
>> +			if [ "$${line##*[[:space:]]}" == "{" ]; then \
>> +				export multiline=1; \
>> +				printf "%s\n" "$$line" >> "$(TARGET_DIR)"/etc/mpd.conf; \
>> +			else \
>> +				[ $$multiline ] && \
>> +					printf "\t%s\n" "$$line" >> "$(TARGET_DIR)"/etc/mpd.conf; \
>> +				[ ! $$multiline ] && \
>> +					sed 
>> '/#'$${line%%[[:space:]]*}'[^\n]*/,$$!b;//{x;//p;g};//!H;$$!d;x;s||&\n'"$$line"'|' 
>> -i "$(TARGET_DIR)"/etc/mpd.conf; \
>> +			fi \
>> +		elif [ "$$line" == "}" ]; then \
>> +			printf "%s\n" "$$line" >> "$(TARGET_DIR)"/etc/mpd.conf; \
>> +			export multiline=0; \
>> +		fi \
>> +	done < package/mpd/mpd.conf
> 
> I am sorry, but this is way too complicated for Buildroot's KISS
> principle. Some much simpler approach needs to be found.

You might have a point: too much effort for a file that is probably 
never used :-D

> Best regards,
> 
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

Kind regards,
Andreas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot