Re: [Buildroot] [PATCH 4/4] package/gnu-efi: change upstream, bump to 4.0.0

From: Julien Olivain <ju.o@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 4/4] package/gnu-efi: change upstream, bump to 4.0.0
Date: Sun, 19 Jan 2025 13:32:02 +0100	[thread overview]
Message-ID: <8cb7eeb2adac1069fd2d6fcb8565df66@free.fr> (raw)
In-Reply-To: <20250119084511.2816892-5-thomas.petazzoni@bootlin.com>

Hi Thomas,

Thanks for the patches! I applied patches 1 to 3 of this series.

For this patch, "make gnu-efi-legal-info" is failing. See below.

On 19/01/2025 09:45, Thomas Petazzoni wrote:
> https://sourceforge.net/projects/gnu-efi/ is dead and stuck at version
> 3.0.18. At https://sourceforge.net/p/gnu-efi/feature-requests/11/ the
> upstream maintainer has indicated that the project is now maintained
> at https://github.com/ncroxon/gnu-efi/, so let's use this as upstream.
> 
> We can drop patches 0002 and 0003 since they are upstream. Patch 0001
> is just slightly refreshed.
> 
> Changes 3.0.18 -> 3.0.19:
>   https://github.com/ncroxon/gnu-efi/releases/tag/3.0.19
> 
> Changes 3.0.19 -> 4.0.0:
>   https://github.com/ncroxon/gnu-efi/releases/tag/4.0.0

[...]

> diff --git a/package/gnu-efi/gnu-efi.hash 
> b/package/gnu-efi/gnu-efi.hash
> index e059da867e..49d26f868e 100644
> --- a/package/gnu-efi/gnu-efi.hash
> +++ b/package/gnu-efi/gnu-efi.hash
> @@ -1,6 +1,3 @@
> -# From http://sourceforge.net/projects/gnu-efi/files
> -md5  0b93ad70dff96991dd87978fc4275bd1  gnu-efi-3.0.18.tar.bz2
> -sha1  4f12dc4ab3e7940070c87affea17bf8a6209957a  gnu-efi-3.0.18.tar.bz2
>  # Locally computed
> -sha256  
> 7f212c96ee66547eeefb531267b641e5473d7d8529f0bd8ccdefd33cf7413f5c  
> gnu-efi-3.0.18.tar.bz2
> +sha256  
> a2e5dfd25e7fc0cd2027d75dc2517b4c74d94f801ff4784eca557ac1b9835899  
> gnu-efi-4.0.0.tar.gz
>  sha256  
> 42d352e9c28dd446fd0209cd6f75588c8e41f0934540bb382bbd61c752360265  
> README.efilib

It seems the license file "README.efilib" has beed renamed to
"licenses/LICENSE.efilib", see:
https://github.com/ncroxon/gnu-efi/commit/2a3244d2e532ea3c73d8cb2b58d1870c7bcd0c90

Also, new license files "LICENSE" and "licenses/LICENSE.edk2" has
been added in:
https://github.com/ncroxon/gnu-efi/commit/2a3244d2e532ea3c73d8cb2b58d1870c7bcd0c90

> diff --git a/package/gnu-efi/gnu-efi.mk b/package/gnu-efi/gnu-efi.mk
> index 2eed4e40d2..4b9a6a7cd5 100644
> --- a/package/gnu-efi/gnu-efi.mk
> +++ b/package/gnu-efi/gnu-efi.mk
> @@ -4,9 +4,8 @@
>  #
>  
> ################################################################################
> 
> -GNU_EFI_VERSION = 3.0.18
> -GNU_EFI_SOURCE = gnu-efi-$(GNU_EFI_VERSION).tar.bz2
> -GNU_EFI_SITE = http://downloads.sourceforge.net/project/gnu-efi
> +GNU_EFI_VERSION = 4.0.0
> +GNU_EFI_SITE = $(call github,ncroxon,gnu-efi,$(GNU_EFI_VERSION))
>  GNU_EFI_INSTALL_STAGING = YES
>  GNU_EFI_LICENSE = BSD-3-Clause and/or GPL-2.0+ (gnuefi), BSD-3-Clause 
> (efilib)

We should add "BSD-2-Clause-Patent (EDK2 routines)" in _LICENSE.

>  GNU_EFI_LICENSE_FILES = README.efilib

Here, we should have something like:
GNU_EFI_LICENSE_FILES = LICENSE licenses/LICENSE.edk2 
licenses/LICENSE.efilib

Can you send a v2 with those license info updated, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot