Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dimi Tomov <dimi@tpm.dev>
To: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 15/33] package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON
Date: Mon, 15 Aug 2022 20:46:04 +0300	[thread overview]
Message-ID: <8e524c0dd15e9f344bdf10cedea33548@tpm.dev> (raw)
In-Reply-To: <20220814233845.2247022-16-ricardo.martincoski@gmail.com>

This is intended and not a typo.

If you rename BR2_PACKAGE_WOLFTPM_NUVOTON to ... NPCT750 it would not 
match the actual wolfTPM options that is "--enable-nuvoton".

Here is our motivation:
--enable-st33 enables capabilities ONLY for STMicroelectronics ST33.
--enable-nuvoton enables capabilities ONLY for NPCT750.

I remember that the reason behind choosing nuvoton over npct750 for the 
config name is because of the difficulty to remember it in comparison 
with st33.

Also, the package/wolftpm/Config.in clearly explains in one sentence 
what this option does.

Thank you for addressing this Ricardo.

Regards,
Dimi
-- 
Founder of TPM.dev

On 2022-08-15 02:38 AM, Ricardo Martincoski wrote:
> The typo was added by commit 'd0dcc62c4b package/wolftpm: Add config
> options for TPM 2.0 extra capabilities'
> 
> Cc: Dimitar Tomov <dimi@tpm.dev>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
>  package/wolftpm/wolftpm.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/wolftpm/wolftpm.mk b/package/wolftpm/wolftpm.mk
> index d3f693a62e..7e8a108585 100644
> --- a/package/wolftpm/wolftpm.mk
> +++ b/package/wolftpm/wolftpm.mk
> @@ -41,7 +41,7 @@ else
>  WOLFTPM_CONF_OPTS += --disable-st33
>  endif
> 
> -ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y)
> +ifeq ($(BR2_PACKAGE_WOLFTPM_NUVOTON),y)
>  WOLFTPM_CONF_OPTS += --enable-nuvoton
>  else
>  WOLFTPM_CONF_OPTS += --disable-nuvoton
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-15 17:46 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14 23:38 [Buildroot] [PATCH 00/33] fix typos Ricardo Martincoski
2022-08-14 23:38 ` [Buildroot] [PATCH 01/33] package/tclap: fix typo on help Ricardo Martincoski
2022-08-15  9:52   ` Thomas Huth
2022-09-16 11:39   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 02/33] package/ti-gfx: " Ricardo Martincoski
2022-09-16 11:39   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 03/33] package/gcnano-binaries: " Ricardo Martincoski
2022-09-16 11:39   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 04/33] package/ace: fix typo on variable names Ricardo Martincoski
2022-09-16 11:39   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 05/33] package/c-capnproto: use space after depends on Ricardo Martincoski
2022-09-16 11:39   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 06/33] package/kvm-unit-tests: do not use "select...if SYMBOL=y" Ricardo Martincoski
2022-08-15  9:51   ` Thomas Huth
2022-09-16 11:39   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 07/33] Config.in.legacy: add missing select Ricardo Martincoski
2022-09-16 11:40   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 08/33] package/libvncserver: fix typo on BR2_nios2 Ricardo Martincoski
2022-09-16 11:40   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 09/33] package/libgpg-error: fix typo for BR2_aarch64_be Ricardo Martincoski
2022-09-16 11:40   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 10/33] package/freeswitch: fix typo on BR2_powerpc64le Ricardo Martincoski
2022-09-16 11:40   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 11/33] package/uclibc: drop old SPARC symbols Ricardo Martincoski
2022-09-16 11:40   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 12/33] package/tcf-agent: drop bogus BR2_powerpcle Ricardo Martincoski
2022-09-16 11:40   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 13/33] package/qemu: fix typo on STAGING_DIR Ricardo Martincoski
2022-09-16 11:40   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 14/33] package/tesseract-ocr: fix typo on BR2_PACKAGE_TESSERACT_OCR_LANG_GER Ricardo Martincoski
2022-09-16 11:41   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 15/33] package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON Ricardo Martincoski
2022-08-15 17:46   ` Dimi Tomov [this message]
2022-08-15 18:03     ` Yann E. MORIN
2022-08-15 20:10       ` Dimi Tomov
2022-08-14 23:38 ` [Buildroot] [PATCH 16/33] package/kodi: fix typo on BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11 Ricardo Martincoski
2022-09-16 11:41   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 17/33] package/sconeserver: fix typo on BR2_STATIC_LIBS Ricardo Martincoski
2022-09-16 11:41   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 18/33] package/libglvnd: fix typo on BR2_PACKAGE_XORGPROTO Ricardo Martincoski
2022-09-16 11:41   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 19/33] boot/optee-os: fix typo on BR2_TARGET_OPTEE_OS_LATEST Ricardo Martincoski
2022-08-14 23:38 ` [Buildroot] [PATCH 20/33] package/busybox: fix typo on BR2_PACKAGE_NETCAT_OPENBSD Ricardo Martincoski
2022-09-16 11:42   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 21/33] package/jquery-ui-themes: fix typo on BR2_PACKAGE_JQUERY_UI_THEMES_VADER Ricardo Martincoski
2022-09-16 11:42   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 22/33] package/gstreamer1/gst1-plugins-bad: fix typo on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS Ricardo Martincoski
2022-09-16 11:42   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 23/33] package/pcsc-lite: fix typo on BR2_PACKAGE_PCSC_LITE_* Ricardo Martincoski
2022-09-16 11:42   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 24/33] package/zeek: drop bogus PYTHON3_HASHLIB Ricardo Martincoski
2022-08-14 23:38 ` [Buildroot] [PATCH 25/33] package/cups: drop bogus libpaper dependency Ricardo Martincoski
2022-09-16 11:42   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 26/33] package/ranger: drop bogus BR2_PACKAGE_PYTHON_PYC_ONLY Ricardo Martincoski
2022-09-16 11:43   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 27/33] package/openocd: drop bogus BR2_PACKAGE_OPENOCD_ZY1000* Ricardo Martincoski
2022-09-16 11:43   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 28/33] package/directfb: drop bogus BR2_PACKAGE_DIRECTFB_CYBER5K Ricardo Martincoski
2022-09-16 11:43   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 29/33] package/x11r7/xserver_xorg-server: drop bogus BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS Ricardo Martincoski
2022-09-16 11:43   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 30/33] package/gstreamer1/gst1-plugins-good: drop bogus BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB Ricardo Martincoski
2022-09-16 11:44   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 31/33] package/libsepol: drop bogus BR2_TOOLCHAIN_HEADERS_AT_LEAST_2_6 Ricardo Martincoski
2022-09-16 11:44   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 32/33] package/python-pygame: drop bogus BR2_PACKAGE_PYTHON_PYGAME_MIXER_MUSIC Ricardo Martincoski
2022-09-16 11:44   ` Peter Korsgaard
2022-08-14 23:38 ` [Buildroot] [PATCH 33/33] utils/check-symbols: new script Ricardo Martincoski
2022-08-15  9:33   ` Thomas Petazzoni via buildroot
2022-08-15 14:49     ` Arnout Vandecappelle
2022-08-15  9:29 ` [Buildroot] [PATCH 00/33] fix typos Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e524c0dd15e9f344bdf10cedea33548@tpm.dev \
    --to=dimi@tpm.dev \
    --cc=buildroot@buildroot.org \
    --cc=ricardo.martincoski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox