From mboxrd@z Thu Jan  1 00:00:00 1970
From: Romain Naour <romain.naour@gmail.com>
Date: Sun, 3 Jul 2016 09:53:30 +0200
Subject: [Buildroot] [PATCH 02/24 v2] system: sysvinit only selects
 busybox-show-others if busybox is enabled
In-Reply-To: <a6739dce77434d44e657409dcc953ec3532789c1.1466622379.git.yann.morin.1998@free.fr>
References: <cover.1466622379.git.yann.morin.1998@free.fr>
 <a6739dce77434d44e657409dcc953ec3532789c1.1466622379.git.yann.morin.1998@free.fr>
Message-ID: <927864ad-b946-bf1a-8317-c8244fc8358a@gmail.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hi Yann,

Le 22/06/2016 ? 21:07, Yann E. MORIN a ?crit :
> BR2_PACKAGE_BUSYBOX_SHOW_OTHERS is a bit special. When Busybox is
> enabled, it is a Busybox option. When Busybox is not enabled, it is a
> stand-alone option, forcibly enabled.
> 
> So we can safely 'select' it without ensuring (via a 'depends on' or
> another 'select') that Busybox is enabled.
> 
> However, the name of this option does not express the fact that it is
> safe to select it without checking Busybox, which can lead to a bit of
> time-consuming head-scratching.
> 
> To avoid future puzzlement from an unsuspecting observer, consider this
> to be a Busybox option, and only select it when Busybox is enabled.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>

Reviewed-by: Romain Naour <romain.naour@gmail.com>

Not related to your patch but should we do the same change for tovid and systemd
packages which select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS ?

Best regards,
Romain

> 
> ---
> Changes v1 -> v2:
>   - only select if busybox is enabled  (Thomas)
> 
> ---
> Hopefully, this will avoid people to go hunting like I did, and loose a
> few precious minutes of hair-pulling... ;-]
> ---
>  system/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 9441467..2d20230 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -74,7 +74,7 @@ config BR2_INIT_BUSYBOX
>  
>  config BR2_INIT_SYSV
>  	bool "systemV"
> -	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # sysvinit
> +	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS if BR2_PACKAGE_BUSYBOX # sysvinit
>  	select BR2_PACKAGE_INITSCRIPTS
>  	select BR2_PACKAGE_SYSVINIT
>  
>