Re: [Buildroot] [PATCH v4] support/scripts/fix-rpath: parallelize patching files

From: David Laight <David.Laight@ACULAB.COM>
To: 'Victor Dumas' <dumasv.dev@gmail.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v4] support/scripts/fix-rpath: parallelize patching files
Date: Tue, 15 Nov 2022 08:47:58 +0000	[thread overview]
Message-ID: <9d9a3bbf2cfd4f60b82a47087ef8ecba@AcuMS.aculab.com> (raw)
In-Reply-To: <20221020115512.483686-1-dumasv.dev@gmail.com>

From: Victor Dumas
> Sent: 20 October 2022 12:55
> 
> Using "xargs" instead of "while read" loop allows for the patching of files to be parallelized
> This significantly reduces the amount of time it takes to fix all the paths.
> On a larger RFS(~300MB) this script was taking 5 minutes, it now only takes about 30s on a 12 core
> machine
...
> +    # Limit the number of cores used
> +    procs=$(echo -e "$(($(nproc)-2)) \n 1" | sort -n | tail -n1)
> +    find "${rootdir}" ${find_args[@]} | xargs -0 -r -P ${procs} -I {} bash -c "patch_file
> '${PATCHELF}' '${rootdir}' '${sanitize_extra_args}' $@" _ {}

Are you sure that all versions of xargs the script needs to
run on support -P ?

Having xargs run 'bash -c "command" ...' and the quoting also looks odd.
I presume there is some reason xargs can't just run patrch_file.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot