Re: [Buildroot] [PATCH RFC 2/2] package/swtpm: add host package

["Jarkko Sakkinen" <jarkko@kernel.org>]

On Fri Mar 22, 2024 at 10:35 AM EET, Jarkko Sakkinen wrote:
> On Fri, 2024-03-22 at 10:22 +0200, Jarkko Sakkinen wrote:
> > On Thu, 2024-03-21 at 16:30 -0400, Stefan Berger wrote:
> > > 
> > > 
> > > On 3/21/24 14:21, Jarkko Sakkinen wrote:
> > > > Add swtpm and its dependency libtpms to host packages. These are
> > > > useful
> > > > for emulating TPM in QEMU environment.
> > > > 
> > > > Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> > > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > > > ---
> > > 
> > > > +---
> > > > + configure.ac | 16 ++++++++--------
> > > > + 1 file changed, 8 insertions(+), 8 deletions(-)
> > > > +
> > > > +diff --git a/configure.ac b/configure.ac
> > > > +index 49caf96..4acc763 100644
> > > > +--- a/configure.ac
> > > > ++++ b/configure.ac
> > > > +@@ -394,20 +394,20 @@ AS_IF([test "x$enable_default_pcr_banks"
> > > > !=
> > > > "x"],[
> > > > + pcr_bank_checks
> > > > + AC_SUBST([DEFAULT_PCR_BANKS])
> > > > +
> > > > +-AC_PATH_PROG([EXPECT], expect)
> > > > +-if test "x$EXPECT" = "x"; then
> > > > +-	AC_MSG_ERROR([expect is required: expect package])
> > > > +-fi
> > > > ++# AC_PATH_PROG([EXPECT], expect)
> > > > ++# if test "x$EXPECT" = "x"; then
> > > > ++# 	AC_MSG_ERROR([expect is required: expect package])
> > > > ++# fi
> > > > +
> > > > + AC_PATH_PROG([GAWK], gawk)
> > > > + if test "x$GAWK" = "x"; then
> > > > + 	AC_MSG_ERROR([gawk is required: gawk package])
> > > > + fi
> > > > +
> > > > +-AC_PATH_PROG([SOCAT], socat)
> > > > +-if test "x$SOCAT" = "x"; then
> > > > +-	AC_MSG_ERROR([socat is required: socat package])
> > > > +-fi
> > > > ++# AC_PATH_PROG([SOCAT], socat)
> > > > ++# if test "x$SOCAT" = "x"; then
> > > > ++# 	AC_MSG_ERROR([socat is required: socat package])
> > > > ++# fi
> > > 
> > > 
> > > cat and expect are used for running the test cases. When not
> > > running 
> > > the tests then an alternative to commenting the above out may be to
> > > do 
> > > the following before running autogen.sh:
> > > 
> > > tmpdir=$(mktemp -d) || exit 1
> > > cp /usr/bin/true "${tmpdir}/socat"
> > > cp /usr/bin/true "${tmpdir}/expect"
> > > 
> > > PATH=$PATH:${tmpdir}
> > > ./autogen --prefix=...
> > > rm -rf "${tmpdir}"
> > > 
> > >      Stefan
> > 
> > ... which would be more tedious than simply commenting them out
> > because then you would have to tweak the build itself with manual
> > steps instead of using autotools build command.
> > 
> > Up until this is fixed in the upstream project, we are better off
> > simply commenting them out, as they are test dependency, not a build
> > dependency for building e.g. initramfs image or some other type of
> > OS image.
>
> And there's a lot of shenanigans related to the cross-compilation
> environment, which render out the suggestion anyway in that form.
>
> It's a bug because neither socat nor expect are actua build
> dependencies, and the patch works around the bug.

I put out an issue:

https://github.com/stefanberger/swtpm/issues/843

It's not a huge problem for BuildRoot as the build version is always
fixed. We can update the version in BuildRoot and remove the patch
when the time comes.

This is a bigger issue than swtpm in autotools projects. Most of them
have test suites that are not compatible with cross-compilation but
instead assume implicitly that the machine which builds is also the
one that runs the tests, which does not hold when building full OS
images.

BR, Jarkko
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot