Re: [Buildroot] [PATCH v2] support/testing/infra/emulator.py: fix qemu prompt detection

[Brandon Maier via buildroot <buildroot@buildroot.org>]

Hi Thomas,

On Mon Jul 22, 2024 at 1:11 PM UTC, Thomas Petazzoni via buildroot wrote:
> On Fri, 12 Jul 2024 19:31:04 +0000
> Brandon Maier via buildroot <buildroot@buildroot.org> wrote:
>
> > From: Brandon Maier via buildroot <buildroot@buildroot.org>
> > 
> > The qemu.run() method can break when a command happens to output the
> > string "# " to stdout. This is because qemu.run() detects when a command
> > has completed by searching for the shell prompt, which by default is
> > "# ". It then captures everything before the "# " as the commands
> > output, causing the rest of output to be lost.
> > 
> > Instead use the pexpect libraries REPLWrapper to handle running
> > commands. It has hooks to set a custom prompt and avoid some other
> > pitfalls of wrapping a shell.
> > 
> > Signed-off-by: Brandon Maier <brandon.maier@collins.com>
> > ---
> > I tested this against a couple tests and test_bash.py which Yann noticed
> > is special in Julian patch series. I am running a full test run but
> > that will take awhile, so sending this in the meantime for review.
>
> It seems like this change has broken one test:
>
>   https://gitlab.com/buildroot.org/buildroot/-/jobs/7391792869
>
> Traceback (most recent call last):
>   File "/builds/buildroot.org/buildroot/support/testing/tests/init/test_none.py", line 26, in test_run
>     out, exit_code = self.emulator.run("sh -c 'echo $PPID'")
>   File "/builds/buildroot.org/buildroot/support/testing/infra/emulator.py", line 153, in run
>     output = self.repl.run_command(cmd, timeout=timeout)
> AttributeError: 'NoneType' object has no attribute 'run_command'
>
> Could you have a look perhaps?

I already sent a fix for this ;)

https://patchwork.ozlabs.org/project/buildroot/patch/20240715-support-testing-fix-testinitsystemnone-v1-2-299145b2d342@collins.com/

Thanks,
Brandon

>
> Thanks a lot!
>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot