From: Brandon Maier via buildroot <buildroot@buildroot.org>
To: "Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
<buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/mtd: fix zlib build
Date: Tue, 23 Jul 2024 12:27:58 +0000 [thread overview]
Message-ID: <D2WX2I1CFMB0.2XW0UB74YZV37@collins.com> (raw)
In-Reply-To: <20240723095614.993000-1-fontaine.fabrice@gmail.com>
Hi Fabric,
On Tue Jul 23, 2024 at 9:56 AM UTC, Fabrice Fontaine wrote:
> Commit bb19ffeaab5ba4be0a1033ca326b25d4d4e8203f forgot to move
> host-pkgconf dependency from BR2_PACKAGE_MTD_JFFS_UTILS condition to the
> new BR2_PACKAGE_ZLIB condition resulting in the following build failure:
>
> hecking for ZLIB... no
> configure: error: cannot find zlib
>
> Fixes: bb19ffeaab5ba4be0a1033ca326b25d4d4e8203f
> - http://autobuild.buildroot.org/results/7cbeead738af6302d5f0048a443e3b57d6776bb2
Thank you for fixing this!
Brandon Maier
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/mtd/mtd.mk | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
> index fe40cf6c06..d3444c88f2 100644
> --- a/package/mtd/mtd.mk
> +++ b/package/mtd/mtd.mk
> @@ -28,7 +28,7 @@ MTD_CONF_OPTS += --without-lzo
> endif
>
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> -MTD_DEPENDENCIES += zlib
> +MTD_DEPENDENCIES += host-pkgconf zlib
> MTD_CONF_OPTS += --with-zlib
> else
> MTD_CONF_OPTS += --without-zlib
> @@ -37,7 +37,6 @@ endif
> MTD_CONF_ENV += LDFLAGS="$(MTD_LDFLAGS)"
>
> ifeq ($(BR2_PACKAGE_MTD_JFFS_UTILS),y)
> -MTD_DEPENDENCIES += host-pkgconf
> MTD_CONF_OPTS += --with-jffs
> else
> MTD_CONF_OPTS += --without-jffs
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-23 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 9:56 [Buildroot] [PATCH 1/1] package/mtd: fix zlib build Fabrice Fontaine
2024-07-23 10:24 ` Thomas Petazzoni via buildroot
2024-07-23 12:27 ` Brandon Maier via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2WX2I1CFMB0.2XW0UB74YZV37@collins.com \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox