Re: [Buildroot] [PATCH 1/2] package/rpi-utils: new package

["Gaël PORTAY" <gael.portay@gmail.com>]

Thomas,

On Thu Jul 25, 2024 at 10:10 AM CEST, Thomas Petazzoni wrote:
> Well, your patch was not including package/rpi-utils/Config.in, so the
> option BR2_PACKAGE_RPI_UTILS does not exist. Perhaps why it gets
> skipped?
>

So there is a build issue with the uclibc toolchains because of
reallocarray().

	gportay@archlinux ~/src/buildroot $ utils/test-pkg -p rpi-utils
	                    bootlin-armv5-uclibc [1/6]: FAILED
	                     bootlin-armv7-glibc [2/6]: OK
	                   bootlin-armv7m-uclibc [3/6]: SKIPPED
	                     bootlin-x86-64-musl [4/6]: OK
	                      br-arm-full-static [5/6]: SKIPPED
	                             arm-aarch64 [6/6]: OK

See:

	/home/gportay/br-test-pkg/bootlin-armv5-uclibc/build/rpi-utils-a1d522f0f1b50858a44fac80523a2bd80098e789/pinctrl/pinctrl.c: In function ‘do_gpio_poll_add’:
	/home/gportay/br-test-pkg/bootlin-armv5-uclibc/build/rpi-utils-a1d522f0f1b50858a44fac80523a2bd80098e789/pinctrl/pinctrl.c:268:18: error: implicit declaration of function ‘reallocarray’ [-Werror=implicit-function-declaration]
	  268 |     poll_gpios = reallocarray(poll_gpios, num_poll_gpios + 1,
	      |                  ^~~~~~~~~~~~
	/home/gportay/br-test-pkg/bootlin-armv5-uclibc/build/rpi-utils-a1d522f0f1b50858a44fac80523a2bd80098e789/pinctrl/pinctrl.c:268:16: error: assignment to ‘struct poll_gpio_state *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
	  268 |     poll_gpios = reallocarray(poll_gpios, num_poll_gpios + 1,
	      |                ^
	In function ‘gencmd’,
	    inlined from ‘main’ at /home/gportay/br-test-pkg/bootlin-armv5-uclibc/build/rpi-utils-a1d522f0f1b50858a44fac80523a2bd80098e789/vcgencmd/vcgencmd.c:152:14:
	/home/gportay/br-test-pkg/bootlin-armv5-uclibc/build/rpi-utils-a1d522f0f1b50858a44fac80523a2bd80098e789/vcgencmd/vcgencmd.c:109:4: warning: ‘strncat’ specified bound 1024 equals destination size [-Wstringop-overflow=]
	  109 |    strncat (  ~~~~~~~~~~

Do you want me to make a patch? or works around for it using Kconfig?

	config BR2_PACKAGE_RPI_UTILS
		(...)
		depends on !BR2_TOOLCHAIN_USES_UCLIBC # no reallocarray

	comment "rpi-utils needs a glibc or musl toolchain w/ threads"
	        depends on BR2_TOOLCHAIN_USES_UCLIBC

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot