Re: [Buildroot] [PATCH 1/2] configs: add Raspberry Pi Zero 2 W 64-bit defconfig

["Gaël PORTAY" <gael.portay@gmail.com>]

Hello Thomas,

On Thu Aug 8, 2024 at 6:42 PM CEST, Thomas Petazzoni wrote:
> Thanks for this patch. The commit title should be:
>
> 	configs/raspberrypizero2w_64: new defconfig
>

Wow, dit I really make that commit title?!?

Fixed in v2.

> > ---
> >  board/raspberrypi/config_zero2w_64bit.txt | 32 +++++++++++++++
> >  board/raspberrypizero2w-64                |  1 +
> >  configs/raspberrypizero2w_64_defconfig    | 48 +++++++++++++++++++++++
> >  3 files changed, 81 insertions(+)
> >  create mode 100644 board/raspberrypi/config_zero2w_64bit.txt
> >  create mode 120000 board/raspberrypizero2w-64
> >  create mode 100644 configs/raspberrypizero2w_64_defconfig
>
> Please add an entry in the DEVELOPERS file for this new defconfig.
> Perhaps you also want to add yourself for all Raspberry platforms?
>

Okay.

>
> > diff --git a/board/raspberrypizero2w-64 b/board/raspberrypizero2w-64
> > new file mode 120000
> > index 0000000000..fcdafc81ed
> > --- /dev/null
> > +++ b/board/raspberrypizero2w-64
> > @@ -0,0 +1 @@
> > +raspberrypi
>
> I really don't understand why we have all those symlinks, it makes no
> sense. If all defconfigs are using the same files from
> board/raspberrypi/, why are the defconfigs not all using
> board/raspberrypi/ instead of those silly symlinks?
>

They exist since a lot of time now. I have removed them and I hope I
have not missed something.

I hope the br2-external do not use them, or they will have to update the
path.

> > diff --git a/configs/raspberrypizero2w_64_defconfig b/configs/raspberrypizero2w_64_defconfig
> > new file mode 100644
> > index 0000000000..7c36183a9f
> > --- /dev/null
> > +++ b/configs/raspberrypizero2w_64_defconfig
> > @@ -0,0 +1,48 @@
> > +BR2_aarch64=y
> > +BR2_cortex_a53=y
> > +BR2_ARM_FPU_VFPV4=y
> > +
> > +# patches
> > +BR2_GLOBAL_PATCH_DIR="board/raspberrypi/patches"
>
> Here you're not even using that new symlink.
>

Well, I have make a copy of the existing raspberrypizero2w_defconfig; I
have not noticed that incoherence :)

> > +BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
> > +
> > +# Linux headers same as kernel, a 6.6 series
> > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
> > +
> > +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> > +
> > +BR2_LINUX_KERNEL=y
> > +BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> > +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,raspberrypi,linux,576cc10e1ed50a9eacffc7a05c796051d7343ea4)/linux-576cc10e1ed50a9eacffc7a05c796051d7343ea4.tar.gz"
> > +BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi3"
> > +
> > +# Build the DTB from the kernel sources
> > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2710-rpi-zero-2-w"
> > +
> > +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> > +
> > +BR2_PACKAGE_RPI_FIRMWARE=y
> > +BR2_PACKAGE_RPI_FIRMWARE_BOOTCODE_BIN=y
> > +BR2_PACKAGE_RPI_FIRMWARE_VARIANT_PI=y
> > +BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE="board/raspberrypizero2w-64/config_zero2w_64bit.txt"
>
> But here you're using it.
>
> Could you fix that up and send a new iteration?
>

I have "fixed" it.

Would you mind makeing sure I have not missed a thing? I have rebuild
only the pi5.

> Thanks!
>

My pleasure ;)

> Thomas

Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot