Re: [Buildroot] [PATCH] boot/uboot: fix dependency on xilinx-prebuilt

From: Brandon Maier via buildroot <buildroot@buildroot.org>
To: "Frager, Neal" <neal.frager@amd.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>,
	"luca.ceresoli@bootlin.com" <luca.ceresoli@bootlin.com>
Subject: Re: [Buildroot] [PATCH] boot/uboot: fix dependency on xilinx-prebuilt
Date: Mon, 12 Aug 2024 13:01:06 +0000	[thread overview]
Message-ID: <D3DYARJL5VND.19ERKZ05BBC98@collins.com> (raw)
In-Reply-To: <CH2PR12MB5004250FF91D0CADB98CF309F0BB2@CH2PR12MB5004.namprd12.prod.outlook.com>

Hi Neal,

On Sat Aug 10, 2024 at 7:01 AM UTC, Frager, Neal via buildroot wrote:
> Hi Brandon,
>
> > When building with `make -j` and PER_PACKAGE_DIRECTORIES, a race
> > condition occurs between xilinx-prebuilt and u-boot, resulting in the
> > following error.
>
> >  objcopy -O binary -I elf32-little .../images/pmufw.elf .../images/pmufw.bin
> >  objcopy: '.../images/pmufw.elf': No such file
>
> > U-Boot registers a KCONFIG_FIXUP_CMD that uses the pmufw.elf from
> > xilinx-prebuilt. But KCONFIG_FIXUP_CMDS does not use the normal
> > DEPENDENCIES, so xilinx-prebuilt is not guaranteed to have run before
> > fixup.
>
> > Instead move the `objcopy` call out to a PRE_BUILD_HOOK so it will run
> > after xilinx-prebuilt has finished.
>
> > Signed-off-by: Brandon Maier <brandon.maier@collins.com>
>
> Thank you for looking into this.  I am adding Luca on copy as he developed
> the uboot.mk code you are modifying.
>
> Shouldn't line 448 of u-boot.mk prevent this issue?
> UBOOT_DEPENDENCIES += xilinx-prebuilt

It doesn't, the dependency graph looks something like this

  UBOOT_KCONFIG_DEPENDENCIES -> uboot-kconfig
  uboot-kconfig -> uboot-configure
  UBOOT_DEPENDENCIES -> uboot-configure

The `objcopy` call is happening during `uboot-kconfig`, so
UBOOT_DEPENDENCIES is not a prerequisite.

There is a UBOOT_KCONFIG_DEPENDENCIES, but it seemed more appropriate
that the `objcopy` should be a build step.

>
> Do you have the following config when you see this error?
> BR2_TARGET_UBOOT_ZYNQMP_PMUFW_PREBUILT

Yes, this happened when I was building configs/zynqmp_zcu106_defconfig
but with PER_PACKAGE_DIRECTORIES enabled, to speed up build with.

>
> Best regards,
> Neal Frager
> AMD
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot