Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle via buildroot <buildroot@buildroot.org>
To: "Niklas Cassel" <Niklas.Cassel@wdc.com>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>,
	"Kilian Zinnecker" <kilian.zinnecker@mail.de>,
	"Damien Le Moal" <dlemoal@kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Niklas Cassel" <cassel@kernel.org>
Subject: Re: [Buildroot] [PATCH v3 1/2] linux: add support for device tree overlays
Date: Fri, 13 Dec 2024 10:35:37 +0100	[thread overview]
Message-ID: <D6AGYGCVAEYN.F84LYRW2DRTV@kernel.org> (raw)
In-Reply-To: <Z1v5werOKAXaX2iW@ryzen>


[-- Attachment #1.1: Type: text/plain, Size: 2636 bytes --]

Hi Niklas,

> > > -Dropped support for out-of-tree device tree overlays, as Linux 6.12 no
> > >  longer supports building an out-of-tree device tree by simply copying
> > >  it to the kernel source directory (without also modifying the Makefile).
> > 
> > Why is that? As it seems, it is not possible to compile it by simply
> > copying to arch/<arch>/dts (which is buildroot doing currently)
> > anymore. But copying it to arch/<arch>/dts/<vendor>/ is working.
> > Correct?
>
> I'm assuming that neither works anymore, see:
> https://lore.kernel.org/buildroot/CAFOYHZDQmMRuK76TpOSAOFPdqAb4gpw=LNKfmpu=sqAD1EMhFg@mail.gmail.com/T/#u
> https://lore.kernel.org/all/CAK7LNAR4h6NZ+D0BK+q4VQBeHWpjzRBQFQ9ovBrftM=6dHRcUg@mail.gmail.com/
> https://lore.kernel.org/buildroot/Z1nq_gneO4ORw3EG@curiosity/T/#t

Thanks for the pointers.

But I've just tested both compiling .dts and .dtso from within a
vendor directory and it seems to be working on next-20241213 (?).

> > In that case, we should work on getting support for that in
> > buildroot as well. Esp. buildroot is really lacking copying an
> > actual device tree into that subdir too and currently it's a PITA to
> > include a soc.dtsi for example. If you're using a device tree in
> > buildroot you'd have to use '#include "vendor/soc.dtsi"' while in
> > the kernel (as well as in yocto) you'll just use '#include
> > "soc.dtsi"'.
>
> Yes, it appears that buildroot folks have an idea that it should be possible to
> restore BR2_LINUX_KERNEL_CUSTOM_DTS_PATH in newer kernels by sed:ing the
> Makefile.
>
> However, I don't see any reason to defer this patch until then.
>
>
> Once someone has written a patch that restores BR2_LINUX_KERNEL_CUSTOM_DTS_PATH
> support for recent kernels, you can submit an incremental path on top of this
> that adds support for out-of-tree device tree overlays, if you so wish.
>
> But honestly, considering that the only buildroot configurations that make use of
> BR2_LINUX_KERNEL_CUSTOM_DTS_PATH are:
> - acmesystems_acqua_a5_256mb_defconfig (v6.6)
> - acmesystems_acqua_a5_512mb_defconfig (v6.6)
> - octavo_osd32mp1_brk_defconfig (v5.10)   
> - octavo_osd32mp1_red_defconfig (v5.10)
> - s6lx9_microboard_defconfig (v4.4.7)
>
> are using really old kernel versions, nothing is broken in upstream buildroot,
> so I expect that it might take quite a long time before anyone bothers to
> restore BR2_LINUX_KERNEL_CUSTOM_DTS_PATH support in newer kernels.

This is most useful for buildroot externals which you cannot grep
that easily :) Thus I'd imagine it is more common than you think.

-michael

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-12-13  9:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  8:34 [Buildroot] [PATCH v3 1/2] linux: add support for device tree overlays Niklas Cassel via buildroot
2024-12-13  8:34 ` [Buildroot] [PATCH v3 2/2] configs/rock5b: build and install rock5b " Niklas Cassel via buildroot
2024-12-13  8:53 ` [Buildroot] [PATCH v3 1/2] linux: add support for " Michael Walle via buildroot
2024-12-13  9:09   ` Niklas Cassel via buildroot
2024-12-13  9:35     ` Michael Walle via buildroot [this message]
2024-12-13  9:48       ` Niklas Cassel
2024-12-13 10:03         ` Michael Walle via buildroot
2025-02-04 16:36           ` Romain Naour via buildroot
2024-12-20 10:06 ` Niklas Cassel via buildroot
2025-01-02 11:48   ` Niklas Cassel via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D6AGYGCVAEYN.F84LYRW2DRTV@kernel.org \
    --to=buildroot@buildroot.org \
    --cc=Niklas.Cassel@wdc.com \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=kilian.zinnecker@mail.de \
    --cc=mwalle@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox