Re: [Buildroot] [PATCH v4 1/2] package/rpi-utils: new package

["Gaël PORTAY" <gael.portay+rtone@gmail.com>]

Hello Romain,

On Wed Feb 5, 2025 at 9:44 AM CET, Romain Naour wrote:
> Hello Gaël, All,
>
> Le 04/02/2025 à 18:34, Gaël PORTAY a écrit :
>> The package rpi-userland has been marked as ancient and deprecated[1].
>> 
>> The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
>> the repository rpi-utils since then.
>> 
>> This adds the new package rpi-utils at latest commit as there is no
>> tagged commit.
>
> BR2_PACKAGE_RPI_USERLAND is used in several packages. Since rpi-utils should
> replace rpi-userland maybe it's time to also update theses packages?
>

That is a good catch. But we cannot as rpi-utils does not provides all
the pieces that rpi-userland provides.

> Did you consider not only deprecating rpi-userland but a complete replacement?
>

And thus, the rpi-utils cannot replace entirelly rpi-userland.

So I guess, we should removes the binaries utilities provided by the new
package rpi-utils (dtoverlay, dtmerge, vcmailbox, vcgencmd) from the old
package rpi-userland. And thus, both packages can be installed at the
same time.

What do you think?

>> 
>> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
>> 
>> Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
>> Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
>> ---
>
> What happened since v3?
>

No big changes, it was in the coverletter:

Changes since v3:
 - Update my e-mail
 - Rebase on master
 - Add Tested-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

>>  DEVELOPERS                       |  1 +
>>  package/Config.in                |  1 +
>>  package/rpi-utils/Config.in      | 12 ++++++++++++
>>  package/rpi-utils/rpi-utils.hash |  3 +++
>>  package/rpi-utils/rpi-utils.mk   | 18 ++++++++++++++++++
>>  5 files changed, 35 insertions(+)
>>  create mode 100644 package/rpi-utils/Config.in
>>  create mode 100644 package/rpi-utils/rpi-utils.hash
>>  create mode 100644 package/rpi-utils/rpi-utils.mk
>> 
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index 2da5d178b2..fc1ba2ab27 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -1203,6 +1203,7 @@ F:	package/nginx-modsecurity/
>>  N:	Gaël PORTAY <gael.portay+rtone@gmail.com>
>>  F:	board/raspberrypi/
>>  F:	configs/raspberrypi*
>> +F:	package/rpi-utils/
>>  
>>  N:	Gao Xiang <hsiangkao@aol.com>
>>  F:	package/erofs-utils/
>> diff --git a/package/Config.in b/package/Config.in
>> index e9c789cff2..f02fe52f35 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -454,6 +454,7 @@ menu "Firmware"
>>  	source "package/qoriq-fm-ucode/Config.in"
>>  	source "package/rcw-smarc-sal28/Config.in"
>>  	source "package/rpi-firmware/Config.in"
>> +	source "package/rpi-utils/Config.in"
>>  	source "package/sunxi-boards/Config.in"
>>  	source "package/ts4900-fpga/Config.in"
>>  	source "package/ux500-firmware/Config.in"
>> diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
>> new file mode 100644
>> index 0000000000..a2729167aa
>> --- /dev/null
>> +++ b/package/rpi-utils/Config.in
>> @@ -0,0 +1,12 @@
>> +config BR2_PACKAGE_RPI_UTILS
>> +	bool "rpi-utils"
>
> Since it's only usefull for rpi targets, you should keep the architecture
> dependencies (at least):
>
> 	depends on BR2_arm || BR2_aarch64
>
> Otherwise, it looks ok.
>

Makes sense.

> Best regards,
> Romain
>

Regards,
Gaël
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot