Re: [Buildroot] [PATCH 1/4] package/libxmlsec1: Add libxmlsec1 used by openSCAP

["Alexis Lothoré via buildroot" <buildroot@buildroot.org>]

Hi Thomas,

thanks for the review !
On Wed Jul 30, 2025 at 6:53 PM CEST, Thomas Petazzoni via buildroot wrote:
> Hello Alexis,
>> +LIBXMLSEC1_CONF_OPTS =	--disable-static \
>> +			--enable-crypto-dl=no \
>> +			--with-openssl \
>> +			--with-gnutls=no \
>> +			--with-gcrypt=no \
>> +			--with-nss=no
>
> This should be a bit more nicely formatted, and use --disable/--without
> instead of --enable-..=no and --with-...=no. Also, you shouldn't pass
> --disable-static unless you have a very good reason to. Indeed,
> Buildroot is passing --{enable,disable}-{shared,static} automatically
> based on the BR2_SHARED_LIBS/BR2_STATIC_LIBS settings.
>
> So:
>
> LIBXMLSEC1_CONF_OPTS = \
> 	--disable-crypto-dl \
> 	--with-openssl \
> 	--without-gnutls \
> 	--without-gcrypt \
> 	--without-nss

Yes, I must confess that I did not thoroughly reviewed those conf opts
before including them. I'll give a try without the static, remove it if not
needed, and use proper BR mechanisms if it is actually needed.

[...]

>> +HOST_LIBXMLSEC1_CONF_OPTS = $(LIBXMLSEC1_CONF_OPTS)
>
> I'm not sure I like re-using like this target options for the host
> variant. I think I'd prefer them to be duplicated.

You right, and this pattern actually bit me in one of the other packages
brought in this series !

Alexis


-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot