Re: [Buildroot] [PATCH] package/php-lua: fix build with GCC14

["Alexis Lothoré via buildroot" <buildroot@buildroot.org>]

Hi Thomas,

On Wed Aug 6, 2025 at 10:57 AM CEST, Thomas Petazzoni wrote:
> Hello Alexis,
>
> On Wed, 06 Aug 2025 10:12:49 +0200
> Alexis Lothoré <alexis.lothore@bootlin.com> wrote:
>
>> On Buildroot 2025.02.x, php-lua build fails on the following error:
>
> Buildroot 2025.02.x is one thing, but do you also see the same build
> issue on master?

Yes, I have the build failure on top of master as well (on top of
2fd520c8d52b ("package/glm: bump version to 1.0.1"), to be precise)
>
> Since there's no build failure in our autobuilder (which is kind of
> surprising), could you include in the commit log a snippet of a
> reasonably minimal defconfig that exhibits the issue?

Sure, I'll include it in the next revision. It looks like this:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_NEON=y
BR2_ARM_ENABLE_VFP=y
BR2_ARM_FPU_NEON=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_PACKAGE_LUA=y
BR2_PACKAGE_PHP=y
BR2_PACKAGE_PHP_LUA=y
BR2_PACKAGE_PHP_PECL_DBUS=y

> Also, do you know what caused the failure? I would suspect an update of
> PHP.

If I trust the upstream pending PR, the failure is due to commit
91ef4124e56a ("Refactor zend_object_handlers API to pass zend_object* and
zend_string* insted of zval(s).") in upstream PHP project. I fail to find
the corresponding entry in any PHP changelog, but following the git
history, this has been introduced with PHP 8.0.0. I tried to quickly revert
to PHP 7.4.20, but this version does not even build anymore on
current BR (unrelated build failures)

However I observe that if I switch from Bootlin 'bleeding edge' toolchain
to 'stable' toolchain, php-lua build succeeds on master. So I guess this
issue is a mix of API change and compiler update. When using the stable
toolchain, I see the warning that matches the error I see when using the
bleeding-edge toolchain (-Wincompatible-pointer-types)

>> I've taken a look at the official upstream to make the fix integrated in
>> here as well, but it really looks like a dead end: there has been no
>> activity for 5 years, and the maintainer does not seem to answer PRs or
>> issues. The PR containing the two patches introduced with the BR package
>> has not even been merged. I have been tempted to replace the upstream
>> source with the fork from which I took the patch
>> (https://github.com/badoo/php-lua), which looks slightly less "dead"
>> (last activity 2 years ago, and some work done to update the module
>> compatibility with current PHP major version).  I eventually chose to
>> keep the current upstream and bring this single patch, but please let me
>> know if changing the upstream source would be better.
>
> It's of course annoying to have unmaintained things packaged in
> Buildroot. I guess Nicolas is still using this software component?
>
> Thomas




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot