Re: [Buildroot] [PATCH] package/php-pecl-dbus: fix build with PHP8

From: "Alexis Lothoré via buildroot" <buildroot@buildroot.org>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org,
	"Hervé Codina" <herve.codina@bootlin.com>,
	"Nicolas Carrier" <nicolas.carrier@nav-timing.safrangroup.com>
Subject: Re: [Buildroot] [PATCH] package/php-pecl-dbus: fix build with PHP8
Date: Wed, 06 Aug 2025 14:14:29 +0200	[thread overview]
Message-ID: <DBVC4NHTNJCS.Z7MM8XO0B49K@bootlin.com> (raw)
In-Reply-To: <20250806123423.33451a9c@windsurf>

On Wed Aug 6, 2025 at 12:34 PM CEST, Thomas Petazzoni wrote:
> Hello Alexis,
>
> On Wed, 06 Aug 2025 12:23:59 +0200
> Alexis Lothoré <alexis.lothore@bootlin.com> wrote:
>
>> Yes, I have those issues on the master branch, on 2fd520c8d52b
>> ("package/glm: bump version to 1.0.1")
>
> OK!
>
>> > Is the issue
>> > https://autobuild.buildroot.net/results/e98/e9892bbefa781b403fd3d834b6c48527c8e078ba/build-end.log
>> > perhaps ? If so, please add a reference to the autobuilder failure.  
>> 
>> Yes, that looks like the same issue ! Ok, I'll add a reference.
>
> Perfect.
>
>> > For bug/build fixes, we like to understand since when the problem is
>> > occurring, i.e which commit introduced the regression. If this package
>> > was building on 2024.02 and no longer on 2025.02, I suspect it's one of
>> > the PHP version bump between those two releases:  
>> 
>> The upstream commit in PHP project leading to this issue is actually the
>> same as for the php-lua package (commit 91ef4124e56a ("Refactor
>> zend_object_handlers API to pass zend_object* and zend_string* insted of
>> zval(s)."), so the issue has been introduced when the PHP packaged has been
>> bumped to 8.0.0, not later. And again, I can see the issue with a minimal
>> defconfig _when using bootlin bleeding-edge toolchain_. With stable
>> toolchain, we can spot the corresponding warning in php-dbus build logs,
>> but it is not turned into an actual error.
>
> Ah, OK. I was wondering then why the issue was not happening with
> Buildroot 2024.02 which already had PHP >= 8.0.0.
>
> So it's really the switch to GCC 15.x that exhibits the issue, turning
> it into a hard build error.

I guess you are meaning GCC 14.x :)
And BTW, I see that the change is documented in GCC14 porting guide:
https://gcc.gnu.org/gcc-14/porting_to.html

I'll update the v2 with those details, thanks for the review !

Alexis

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot