Re: [Buildroot] [PATCH v3] package/php-lua: fix build with PHP8/GCC14

["Alexis Lothoré via buildroot" <buildroot@buildroot.org>]

Hi Romain,

On Sun Sep 7, 2025 at 12:17 AM CEST, Romain Naour wrote:
> Hello Alexis, All,
>
> Le 25/08/2025 à 16:53, Alexis Lothoré a écrit :
>> Hi Romain,
>> 
>> On Sun Aug 24, 2025 at 5:36 PM CEST, Romain Naour wrote:
>>> Hello Alexis, Thomas, All,
>>>
>>> Le 11/08/2025 à 09:52, Alexis Lothoré via buildroot a écrit :

[...]

>> My bad for the absence of reaction on my side, I have been off for a few
>> days, and then travelling for conference. Thanks for handling this !
>
> No problem, thanks for your contribution in the first place.
>
> I noticed a new issue in Gitlab-CI that seems related to this patch [1]
> Indeed, the backported commit [2] introduce a build issue with lua < 502
> interpreters due to probably a copy past of this line (val is not defined):
>
>   lua_pushlstring(L, ZSTR_VAL(val), ZSTR_LEN(val));
>
> I guess, we have to replace "val" by "member" since ZSTR_VAL macro uses internal
> "(zstr)->val" (#define ZSTR_VAL(zstr)  (zstr)->val) that seems only available in
> "member". But I may be wrong...
>
>   lua_pushlstring(L, ZSTR_VAL(member), ZSTR_LEN(member));
>
> With that fixed, TestPhpLuaLuajit pass.
>
> Can you have a look?
>
> [1] https://gitlab.com/buildroot.org/buildroot/-/jobs/11176774941
> [2] https://github.com/badoo/php-lua/commit/de1068d634519abf2461dac9427b5ff24b6603af

Sure, I'll look at it and submit the relevant patch.

Alexis
>
> Best regards,
> Romain
>
>
>> 
>> Alexis
>> 
>>> Best regards,
>>> Romain
>>>
>> 




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot