Re: [Buildroot] [PATCH v1 1/1] boot/xilinx-prebuilt: add local versal xsa support

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hello Neal,

On Sat Oct 25, 2025 at 3:46 PM CEST, Neal Frager wrote:
> Most of the time, users will be running Vivado on their local host machine,
> and will generate a XSA (Xilinx Shell Archive) locally.
>
> Instead of requiring users to create a https:// location for their XSA file,
> this patch improves ease of use by allowing users to work directly with the
> XSA file on their local machine.
>
> BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA_LOCATION can thus be defined as either
> a local location or a https:// location for the XSA file.
>
> In either case, a hash for the XSA file needs to be added to the
> boot/xilinx-prebuilt/xilinx-prebuilt.hash when using this option.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
>  boot/xilinx-prebuilt/xilinx-prebuilt.mk | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/boot/xilinx-prebuilt/xilinx-prebuilt.mk b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
> index 95b656cdde..a7ec9abff5 100644
> --- a/boot/xilinx-prebuilt/xilinx-prebuilt.mk
> +++ b/boot/xilinx-prebuilt/xilinx-prebuilt.mk
> @@ -10,6 +10,9 @@ ifeq ($(BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA),y)
>  XILINX_PREBUILT_FILE = $(call qstrip,$(BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA_LOCATION))
>  XILINX_PREBUILT_SITE = $(patsubst %/,%,$(dir $(XILINX_PREBUILT_FILE)))
>  XILINX_PREBUILT_SOURCE = $(notdir $(XILINX_PREBUILT_FILE))
> +ifeq ($(findstring ://,$(XILINX_PREBUILT_FILE)),)
> +XILINX_PREBUILT_SITE_METHOD = file
> +endif

According to the BR2_TARGET_XILINX_PREBUILT_VERSAL_XSA_LOCATION help text,
using a local file is already supported by using the file:// URL prefix.

Can you elaborate on which use case you are adding now? I think you are
just making it a bit easier and cleaner to do the same thing as before by
using a path instead of a URL, but I may be wrong.

Also, updating the Config.in help text should part of this patch.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot