Re: [Buildroot] [PATCH 1/1] package/partclone: new package

From: "Matthew Silva" <dev@matt-silva.com>
To: "Dowan GULLIENT" <dowan.gullient@smile.fr>, <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/partclone: new package
Date: Tue, 12 May 2026 20:14:29 -0400	[thread overview]
Message-ID: <DIH45X0P1THJ.GDBXVFRNLCOA@matt-silva.com> (raw)
In-Reply-To: <CAARUF11ZKthafBn=mLswxnFp==oK=KJXD0PCmqj=JoP8FCbYrw@mail.gmail.com>

Hi Dowan.

Thank you for taking the time to review this, and I appreciate your
patience with my beginner mistakes. Going through to correct the issues
you pointed out has clarified a lot of things for me; I've learned quite
a bit from the experience.

I have addressed all your comments except for number 5. I am
investigating the different ssl providers and then will submit a v2.

A couple quick follow up questions if you don't mind answering:

On Thu Mar 19, 2026 at 6:05 AM EDT, Dowan GULLIENT wrote:
> 1. Architecture dependency:
> The build fails on no-MMU platforms (like ARMv7-M) because partclone
> depends  on util-linux (libuuid) which requires pthread_atfork, which is
> unavailable there.
> Please add "depends on BR2_USE_MMU" in Config.in.

It appears that in util-linux/Config.in, neither the base util-linux
Kconfig option, nor the util-linux libuuid Kconfig option specify a
depends on BR2_USE_MMU. Is there something I am missing something here,
or is this a bug with the Config.in for util-linux? If so, I'll happily
send in a patch.

> 3. Verify the dependency propagation :
> Kconfig does not support propagation of dependances, so in config.in you
> might have to add "depends on ..." to all the dependencies that require it,
> here is few examples but I did not verified all of them :
> Complete
> "   select BR2_PACKAGE_NTFS_3G"
> with
> "   depends on BR2_USE_WCHAR
>     depends on BR2_TOOLCHAIN_HAS_THREADS
>     depends on BR2_USE_MMU
>     depends on !BR2_STATIC_LIBS
>     select BR2_PACKAGE_NTFS_3G"
>
> and modify
> "   depends on BR2_PACKAGE_XFSPROGS"
> with
> "   depends on BR2_PACKAGE_LIBURCU_ARCH_SUPPORTS # xfsprogs
>     depends on BR2_USE_MMU # xfsprogs
>     depends on BR2_TOOLCHAIN_HAS_THREADS # xfsprogs
>     depends on BR2_INSTALL_LIBSTDCPP # xfsprogs
>     depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_9 # xfsprogs
>     select BR2_PACKAGE_XFSPROGS"
>
> That way you will not break the package if you select those features and
> the user only have to select one option.

Is there a reason you didn't mark the NTFS_3G depends with comments like
you did in the XFSPROGS? Right now in my adjustments I have included the
comments for both.

Additionally, I've added Kconfig comments indicating the toolchain
dependencies as mentioned in the docs.

> With these changes, the package passes all 6 toolchains in test-pkg.
> Once you send a v2, I'll be happy to provide my "Tested-by" tag.

I'm curious as to how this works. I see that it is appended to the
commit message. Is this something added by me, you, or the maintainer
who accepts the patch?
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot