Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexis Lothoré via buildroot" <buildroot@buildroot.org>
To: "Thomas Perale" <thomas.perale@mind.be>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: "Alexis Lothoré" <alexis.lothore@bootlin.com>,
	buildroot@buildroot.org,
	"Nicolas Carrier" <nicolas.carrier@nav-timing.safrangroup.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/sass: new package
Date: Mon, 10 Aug 2026 14:25:09 +0200	[thread overview]
Message-ID: <DKL9FUAMHEBJ.2DHVLMRHLWOGZ@bootlin.com> (raw)
In-Reply-To: <20260807115533.97671-1-thomas.perale@mind.be>

On Fri Aug 7, 2026 at 1:55 PM CEST, Thomas Perale wrote:
> Hi Thomas, Alexis,
>
>> I am not super clear on what sass exactly does/is. But some time ago,
>> we dropped all JS libraries from Buildroot:
>> 
>>   https://lore.kernel.org/buildroot/20250829103340.158873-1-thomas.perale@mind.be/
>> 
>> But sass doesn't seem to be one of those static JS libraries I guess
>> because it installs some executable host tool?
>
> If I remember correctly node-sass is build using node-gyp so I can make sense
> to have it in Buildroot because the node-sass version is closely related to the
> node version present in Buildroot.

Just to make sure we are talking about the same thing, this package is
not introducing node-sass ([1]), which is deprecated, but sass ([2])

> The question is how do you plan to use 'node-sass' once you have the executable.
> Correct me if I'm wrong but I guess the goal here is to use it in another
> Buildroot package that represent a "webapp" and you run 'node-sass'
> in the build step of that package and then place the generate css in the
> correct location ?

Correct. To be exact, sass is not currently called directly by the
custom buildroot package for "webapp". "webapp" is a php project, using
composer to install and run "mini-asset" ([3]) which is a bundler
depending on uglify and sass binaries being present on host.

> The correct way handle this (and minification) would probably be to use a
> dedicated JavaScript bundler and configure it to use node-sass and setup
> minification. This would probably yield smaller bundles and help handle
> versioning correctly for your webapp.
> This was also the thinking in dropping the JS libraries from Buildroot.
>
> If you have a `package.json` for the webapp with the node-sass dependency. Can
> you `npm install` the webapp dependencies using the buildroot 'npm'
> host-package without errors ? If that's the case I would say that it is
> probably a better solution.

So in this case I've got no package.json, I only have a composer.json
requiring mini_asset, and mini_asset does not automatically pull those
dependencies. Mini-asset is configured through a .ini file, in which we
can use different "filters" (eg: Sass), and each filter has different
requirements, but it is up to the user to bring those dependencies on
host. One thing that I can check however, close to your suggestion, is
whether there is a different CSS "filter" that could be brought
automatically by composer and that generates something close to what
"webapp" is currently outputting.

Alexis

>
> Best regards,
> PERALE Thomas

[1] https://www.npmjs.com/package/node-sass
[2] https://www.npmjs.com/package/sass
[3] https://github.com/markstory/mini-asset




-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-08-10 12:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 21:24 [Buildroot] [PATCH 0/2] package: bring two host tools Alexis Lothoré via buildroot
2026-08-06 21:24 ` [Buildroot] [PATCH 1/2] package/uglifyjs: new package Alexis Lothoré via buildroot
2026-08-07  7:44   ` Thomas Petazzoni via buildroot
2026-08-10  8:44     ` Alexis Lothoré via buildroot
2026-08-06 21:24 ` [Buildroot] [PATCH 2/2] package/sass: " Alexis Lothoré via buildroot
2026-08-07  8:29   ` Thomas Petazzoni via buildroot
2026-08-07 11:55     ` Thomas Perale via buildroot
2026-08-10 12:25       ` Alexis Lothoré via buildroot [this message]
2026-08-10 21:04         ` Thomas Perale via buildroot
2026-08-10  9:29     ` Alexis Lothoré via buildroot
2026-08-10 12:32       ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKL9FUAMHEBJ.2DHVLMRHLWOGZ@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=alexis.lothore@bootlin.com \
    --cc=nicolas.carrier@nav-timing.safrangroup.com \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox