Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: "Julien Olivain" <ju.o@free.fr>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: buildroot@buildroot.org,
	"Alexis Lothoré" <alexis.lothore@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v3] package/heaptrack: new package
Date: Fri, 21 Aug 2026 21:46:47 +0200	[thread overview]
Message-ID: <DKUVPZAR4HWR.AD1PLPGNKXCE@bootlin.com> (raw)
In-Reply-To: <9de991fb9ed19fb13d2079c3dafde7d5@free.fr>

Hello Julien,

On Sat Aug 15, 2026 at 9:25 PM CEST, Julien Olivain wrote:

>> +++ b/package/heaptrack/Config.in
>> @@ -0,0 +1,37 @@
>> +config BR2_PACKAGE_HEAPTRACK
>> +	bool "heaptrack"
>> +	depends on BR2_INSTALL_LIBSTDCPP
>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # boost, libunwind, elfutils
>> +	depends on BR2_USE_WCHAR # boost, elfutils
>> +	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS #
>> boost-filesystem
>
> This package is failing to build with uclibc toolchains. See:
> https://gitlab.com/jolivain/buildroot/-/pipelines/2762905573
>
> heaptrack uses LM_ID_BASE which is not supported by uclibc:
> https://invent.kde.org/sdk/heaptrack/-/blob/master/src/track/heaptrack_env.cpp#L33
> https://github.com/wbx-github/uclibc-ng/blob/v1.0.59/include/dlfcn.h#L46-L54
>
> You could either try to fix that issue, or disable the package for
> uclibc toolchains by adding:
>
>      depends on !BR2_TOOLCHAIN_USES_UCLIBC # no dlmopen() support
>
> with the corresponding comment.

Thanks for the review and testing!

>> +HEAPTRACK_DEPENDENCIES = host-pkgconf boost libunwind zlib elfutils
>
> Could you sort dependencies, please?

Ah, sure! By a quick look into existing packages I had concluded sorting is
not required.

I'm sending v4 with all the changes you suggested.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-08-21 19:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 10:15 [Buildroot] [PATCH v3] package/heaptrack: new package Luca Ceresoli via buildroot
2026-08-15 19:25 ` Julien Olivain via buildroot
2026-08-21 19:46   ` Luca Ceresoli via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKUVPZAR4HWR.AD1PLPGNKXCE@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=alexis.lothore@bootlin.com \
    --cc=ju.o@free.fr \
    --cc=luca.ceresoli@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox