Re: [Buildroot] [PATCH 1/2] package/webkitgtk: Build with ninja

From: John Keeping <john@metanate.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Adrian Perez de Castro <aperez@igalia.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/webkitgtk: Build with ninja
Date: Fri, 10 Feb 2023 18:46:58 +0000	[thread overview]
Message-ID: <Y+aRIvtdL1ROUUQE@donbot> (raw)
In-Reply-To: <87fsbdg2wb.fsf@dell.be.48ers.dk>

On Fri, Feb 10, 2023 at 12:45:24PM +0100, Peter Korsgaard wrote:
> >>>>> "John" == John Keeping <john@metanate.com> writes:
> 
>  > Hi Peter,
>  > On Thu, Feb 09, 2023 at 06:07:05PM +0100, Peter Korsgaard wrote:
>  >> +define WEBKITGTK_BUILD_CMDS
>  >> +	$(TARGET_MAKE_ENV) $(BR2_CMAKE) --build $(WEBKITGTK_BUILDDIR)
>  >> +endef
>  >> +
>  >> +define WEBKITGTK_INSTALL_STAGING_CMDS
>  >> +	$(TARGET_MAKE_ENV) DESTDIR=$(STAGING_DIR) $(BR2_CMAKE) --install $(WEBKITGTK_BUILDDIR)
>  >> +endef
>  >> +
>  >> +define WEBKITGTK_INSTALL_TARGET_CMDS
>  >> +	$(TARGET_MAKE_ENV) DESTDIR=$(TARGET_DIR) $(BR2_CMAKE) --install $(WEBKITGTK_BUILDDIR)
>  >> +endef
>  >> +
> 
>  > Would it make sense to apply these changes in pkg-cmake.mk?
> 
>  > Using `cmake --build` and `cmake --install` works with all generators
>  > and it would avoid needing to repeat this block for both of the packages
>  > in this series.
> 
> Longer term that is indeed the direction we want to move to (and
> generally build cmake packages with the ninja backend).
> 
> This is meant as a minimal patch that is easy to backport to the stable
> branches.

Makes sense.

> We have a number of cmake packages that use custom FOO_MAKE_OPTS, how
> are those passed to make when using cmake --build / --install?

For building, we have:

	cmake --build <dir> [<options>] [-- <build-tool-options>]

so it should be easy to pass _MAKE_OPTS through.

But I can't see anything similar for --install, although I wonder if
anything actually needs to pass _MAKE_OPTS for installation.

From a quick look only 3 CMake packages use _MAKE_OPTS at all:

	$ git grep -l cmake-package package/ | grep -vF pkg-cmake.mk | xargs grep MAKE_OPTS
	package/gdal/gdal.mk:GDAL_MAKE_OPTS += -f Makefile
	package/mariadb/mariadb.mk:HOST_MARIADB_MAKE_OPTS = import_executables
	package/zeek/zeek.mk:HOST_ZEEK_MAKE_OPTS = binpac bifcl

Of those, gdal's use is probably unnecessary when using `cmake --build`
and the other two could us a more specific option to set targets and use
the --targets option (but should also be okay with passing options after
`--`).

Regards,
John
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot