Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Bisson <gary.bisson@boundarydevices.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/linux-firmware: remove imx sdma firmware
Date: Mon, 18 Jan 2021 09:00:03 +0100	[thread overview]
Message-ID: <YAVAA4aR93t80jKJ@p1g2> (raw)
In-Reply-To: <20210117133119.73546-1-romain.naour@gmail.com>

Hi Romain,

On Sun, Jan 17, 2021 at 02:31:19PM +0100, Romain Naour wrote:
> As reported on the mailing list [1], the imx sdma firmwares for
> imx[6,7,8] are provided by two packages: firmware-imx and
> linux-firmware
> 
> $ sha256sum ./firmware-imx-8.10/firmware/sdma/sdma-imx6q.bin
> 7790c161b7e013a9dbcbffb17cc5d4cb63d952949a505647e4679f02d04c4784
> ./firmware-imx-8.10/firmware/sdma/sdma-imx6q.bin
> 
> $ sha256sum  ./linux-firmware-20201022/imx/sdma/sdma-imx6q.bin
> 7790c161b7e013a9dbcbffb17cc5d4cb63d952949a505647e4679f02d04c4784
> ./linux-firmware-20201022/imx/sdma/sdma-imx6q.bin
> 
> Keep firmware-imx as the only imx sdma firmware provider.
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2021-January/300938.html
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Stephane Viau <stephane.viau@oss.nxp.com>
> Cc: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
>  Config.in.legacy                         | 8 ++++++++
>  package/linux-firmware/Config.in         | 9 ---------
>  package/linux-firmware/linux-firmware.mk | 6 ------
>  3 files changed, 8 insertions(+), 15 deletions(-)
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 3c022d21d7..a322d18cb3 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,14 @@ endif
>  
>  comment "Legacy options removed in 2021.02"
>  
> +config BR2_PACKAGE_LINUX_FIRMWARE_IMX_SDMA
> +	bool "imx sdma firmware is provided by firmware-imx"
> +	select BR2_LEGACY
> +	select BR2_PACKAGE_FIRMWARE_IMX

I know it's too late as Yann already merged that commit, but I believe
the above is wrong. You can't select this option unless
BR2_PACKAGE_FREESCALE_IMX is also defined.

Regards,
Gary

  parent reply	other threads:[~2021-01-18  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17 13:31 [Buildroot] [PATCH] package/linux-firmware: remove imx sdma firmware Romain Naour
2021-01-17 14:22 ` Yann E. MORIN
2021-01-18  8:00 ` Gary Bisson [this message]
2021-01-18 20:32   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAVAA4aR93t80jKJ@p1g2 \
    --to=gary.bisson@boundarydevices.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox