Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	Markus Mayer <mmayer@broadcom.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH 2/3] make: Drop `type -p ...' fallback
Date: Fri, 29 Oct 2021 20:54:28 +0200	[thread overview]
Message-ID: <YXxDZA4TIRolot/b@pevik> (raw)
In-Reply-To: <20211028145212.36dcb38a@camb691.localdomain>

Hi Cyril,

> On Tue, 12 Oct 2021 00:00:24 +0200
> Petr Vorel <petr.vorel@gmail.com> wrote:

> > `command -v' is good enough as it's POSIX.
> > For easier debugging previous problems removed separately.


> On doing some reading[1] I've discovered that this is a minefield.
> Having said that, I'm pretty sure what currently happens isn't
> good either.

> My only concern might be that theres old RHEL (its always RHEL ;))
> systems out there which could break. Some of my coleagues use old RHEL
> VMs for their build machines. I'm going to try and see if I can get
> access but I wouldn't hold up the patch waiting.
Thanks a lot for pointing this out. Which RHEL version do you mean?
Testing it would save me time to install CentOS (if you mean CentOS 6).

> I've given this patch applied with the previous one a test and is
> working fine on my system. I'm wondering if my tested by tag is
> appropriate for the previous patch since I haven't tested it in
> isolation.
Well, if this (i.e. second) patch works previous version should work as well.

> uname -a
> Linux 5.14.12-arch1-1 #1 SMP PREEMPT Wed, 13 Oct 2021 16:58:16
> +0000 x86_64 GNU/Linux

> make --version
> GNU Make 4.3
> Built for x86_64-pc-linux-gnu

> /bin/sh --version
> GNU bash, version 5.1.8(1)-release (x86_64-pc-linux-gnu)

I tested it on similar environment. Tested it also on older distros (Debian
buster (oldstable) and Cent0S 7.

> [1]
> https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then

> Tested-by: Cyril Bur <cyrilbur@gmail.com>
> Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>

<snip>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-29 18:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 22:00 [Buildroot] [RFC PATCH 0/3] make: support: use `command -v' instead of `which' *second try* Petr Vorel
2021-10-11 22:00 ` [Buildroot] [RFC PATCH 1/3] make: support: use `command -v' instead of `which' Petr Vorel
2021-11-11  8:00   ` Yann E. MORIN
2021-11-12 21:55     ` Petr Vorel
2022-07-23 21:28       ` Arnout Vandecappelle
2022-07-24  5:05         ` Petr Vorel
2021-10-11 22:00 ` [Buildroot] [RFC PATCH 2/3] make: Drop `type -p ...' fallback Petr Vorel
2021-10-28 13:52   ` Cyril Bur
2021-10-29 18:54     ` Petr Vorel [this message]
2021-11-11  8:13     ` Yann E. MORIN
2021-11-11 11:20       ` Cyril Bur
2021-10-11 22:00 ` [Buildroot] [RFC PATCH 3/3] support/dependencies: don't check for `which' Petr Vorel
2022-02-22 22:06 ` [Buildroot] [RFC PATCH 0/3] make: support: use `command -v' instead of `which' *second try* Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXxDZA4TIRolot/b@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=cyrilbur@gmail.com \
    --cc=mmayer@broadcom.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox