Re: [Buildroot] [PATCH 2/2] package/wpa_supplicant: fix mesh configuration build

[Sergey Matyukevich <geomatsi@gmail.com>]

Hi Arnout,

> > Consider the following wpa_supplicant configuration:
> > 
> > BR2_PACKAGE_WPA_SUPPLICANT=y
> > BR2_PACKAGE_WPA_SUPPLICANT_NL80211=y
> > BR2_PACKAGE_WPA_SUPPLICANT_AP_SUPPORT=y
> > BR2_PACKAGE_WPA_SUPPLICANT_MESH_NETWORKING=y
> > BR2_PACKAGE_WPA_SUPPLICANT_EAP=y
> > 
> > This configuration fails to build with the following error:
> > 
> > /path/to/output/build/wpa_supplicant-2.10/build/wpa_supplicant/src/common/sae.o: in function `hkdf_expand':
> > sae.c:(.text+0x3c8): undefined reference to `hmac_sha384_kdf'
> > collect2: error: ld returned 1 exit status
> > make[1]: *** [Makefile:1894: wpa_supplicant] Error 1
> > 
> > Looking into wpa_supplicant Makefile:
> > - CONFIG_MESH for some reason needs SAE, so it enables CONFIG_SAE
> > - CONFIG_SAE enables only HMAC_SHA256_KDF
> > 
> > This is apparently not enough. At least HMAC_SHA384_KDF is required
> > for successful build. This commit adds a minimal patch for
> > wpa_supplicant that fixes specified build configuration.
> > 
> > Reported-by: Yegor Yefremov <yegorslists@googlemail.com>
> > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> > ---
> >   .../0001-mesh-enable-HMAC_SHA384_KDF.patch    | 30 +++++++++++++++++++
> >   1 file changed, 30 insertions(+)
> >   create mode 100644 package/wpa_supplicant/0001-mesh-enable-HMAC_SHA384_KDF.patch
> > 
> > diff --git a/package/wpa_supplicant/0001-mesh-enable-HMAC_SHA384_KDF.patch b/package/wpa_supplicant/0001-mesh-enable-HMAC_SHA384_KDF.patch
> > new file mode 100644
> > index 0000000000..d765c1dbbc
> > --- /dev/null
> > +++ b/package/wpa_supplicant/0001-mesh-enable-HMAC_SHA384_KDF.patch
> > @@ -0,0 +1,30 @@
> > +From 08986b7da7e580f5deb570aaa654df38fb23397a Mon Sep 17 00:00:00 2001
> > +From: Sergey Matyukevich <geomatsi@gmail.com>
> > +Date: Sun, 13 Feb 2022 18:26:23 +0300
> > +Subject: [PATCH] mesh: enable HMAC_SHA384_KDF
> > +
> > +Mesh support CONFIG_MESH needs SAE, so it enables CONFIG_SAE.
> > +In its turn, CONFIG_SAE enables only HMAC_SHA256_KDF option.
> > +This is apparently not enough for successful build. At least
> > +HMAC_SHA384_KDF is required for successful build.
> > +
> 
>  You said that this patch was sent to hostapd. If that is true, please add a
> patchwork link for it, like:
> 
> Upstream: https://patchwork.ozlabs.org/project/hostap/patch/20220130074139.2972-1-yegorslists@googlemail.com/
> 
> 
>  However, that patch looks a bit different, so you'll need to explain why.

Suggested solution seems the be slightly simpler.

> Also, you dropped Yegor as an author, that's not very nice...

I didn't. I sent my version of the fix. Communication on hostapd mailing
list usually takes a while. As soon as upstream patch is accepted, we
will replace this one with the upstream one keeping appropriate authorship.
If you still have some concerns, feel free to drop my second patch. 
We will ask Yegor to send his version.

Original discussion:
https://patchwork.ozlabs.org/project/buildroot/patch/20220131194818.2084092-1-geomatsi@gmail.com/

Regards,
Sergey
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot