Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Chien Peter Lin <peterlin@andestech.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: alankao@andestech.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/3] DEVELOPERS: add Yu-Chien Lin to board/andes
Date: Tue, 15 Feb 2022 10:13:20 +0800	[thread overview]
Message-ID: <YgsMQNqzcR1uCli1@APC323> (raw)
In-Reply-To: <674c1c83-4bcf-3740-8f79-184c1a86cda3@benettiengineering.com>

Hi Giulio,

Thanks for your comments.

> On Thu, Feb 10, 2022 at 12:39:07AM +0100, Giulio Benetti wrote:
> > Hi Peter,
> >
> > I review it now,
> >
> > On 25/01/22 06:49, Yu Chien Peter Lin wrote:
> > > This patch provides defconfig and basic support for the Andes
> > > 45 series RISC-V architecture.
> > >
> > > Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> > > Signed-off-by: Alan Kao <alankao@andestech.com>
> ...
> > >   create mode 100644 board/andes/ae350/patches/opensbi/0001-Disable-PIC-explicitly-for-assembling.patch
> > >   create mode 100644 board/andes/ae350/patches/opensbi/0002-Enable-cache-for-opensbi-jump-mode.patch
> > >   create mode 100644 board/andes/ae350/patches/uboot/0001-Fix-mmc-no-partition-table-error.patch
> > >   create mode 100644 board/andes/ae350/patches/uboot/0002-Prevent-fw_dynamic-from-relocation.patch
> > >   create mode 100644 board/andes/ae350/patches/uboot/0003-Fix-u-boot-proper-booting-issue.patch
> > >   create mode 100644 board/andes/ae350/patches/uboot/0004-Enable-printing-OpenSBI-boot-logo.patch
> >
> > Would it be possible for you to upstream these patches? I mean, do you
> > maintain the uboot, opensbi repositories so you can do that?
> > If yes it would be great having no patches at all here.

We have a plan to upstream some of them if the patch is platform specific.
I'll remove them when the u-boot bumps to the future version.

> > > index 0000000000..5e5d70ab25
> > > --- /dev/null
> > > +++ b/board/andes/ae350/ae350.dts
> ...
> > It's a bit out of topic, but with this .dts ^^^ you define and entire
> > SoC+board, shouldn't it be like a .dtsi file for SoC and a .dts file for
> > board?

We would like to remain in this form until new board is available. Thanks.

Regards,
Yu-Chien Peter Lin
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-15  2:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25  5:49 [Buildroot] [PATCH v2 1/3] board/andes: rearrange nds32 folder structure Yu Chien Peter Lin
2022-01-25  5:49 ` [Buildroot] [PATCH v2 2/3] board/andes/ae350: add support for Andes AE350 Yu Chien Peter Lin
2022-02-09 23:39   ` Giulio Benetti
2022-01-25  5:49 ` [Buildroot] [PATCH v2 3/3] DEVELOPERS: add Yu-Chien Lin to board/andes Yu Chien Peter Lin
2022-02-09 23:09   ` Giulio Benetti
2022-02-15  2:13     ` Yu Chien Peter Lin [this message]
2022-02-15  2:22       ` Giulio Benetti
2022-02-09 22:58 ` [Buildroot] [PATCH v2 1/3] board/andes: rearrange nds32 folder structure Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgsMQNqzcR1uCli1@APC323 \
    --to=peterlin@andestech.com \
    --cc=alankao@andestech.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox