Re: [Buildroot] [PATCH] configs/qemu_xtensa_lx60_nommu: use busybox minimal config

["Vincent Stehlé via buildroot" <buildroot@buildroot.org>]

On Sun, Apr 03, 2022 at 05:07:48PM +0200, Arnout Vandecappelle wrote:
> 
> 
> On 29/03/2022 22:51, Vincent Stehlé via buildroot wrote:
> > Update the qemu_xtensa_lx60_nommu_defconfig to use the
> > busybox-minimal.config, to make it more consistent with the other no-MMU
> > defconfigs.
> 
>  That's not a valid reason IMHO. We use the minimal busybox for boards that
> are extremely tight on memory - which is often the case for noMMU boards.
> But if we can spare the size, full busybox is a lot more useable.

Hi Arnout,

Thanks for reviewing this patch.

>  I've marked this patch as Rejected in patchwork, but if there's a good
> reason to do this, we can always recover it.

There is another incentive to using the minimal config on no-MMU platforms: it
fixes the udhcpc error and repairs the network initialization.

Just let me know if you want me to reword the commit message to insist more on
this aspect and submit a v2. Or we can abandon it for good if you prefer.

Best regards,
Vincent.

> 
>  Regards,
>  Arnout
> 
> > 
> > After commit 3de486f8b052 ("package/busybox: fix udhcpc options in minimal
> > config"), this has the benefit of fixing the following network
> > initialization failure:
> > 
> >    udhcpc: invalid option -- b
> > 
> > Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> > Cc: Romain Naour <romain.naour@gmail.com>
> > Cc: Gerome Burlats <gerome.burlats@smile.fr>
> > ---
> >   configs/qemu_xtensa_lx60_nommu_defconfig | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/configs/qemu_xtensa_lx60_nommu_defconfig b/configs/qemu_xtensa_lx60_nommu_defconfig
> > index c4473fb32a..44fb81bd74 100644
> > --- a/configs/qemu_xtensa_lx60_nommu_defconfig
> > +++ b/configs/qemu_xtensa_lx60_nommu_defconfig
> > @@ -7,6 +7,9 @@ BR2_XTENSA_OVERLAY_FILE="https://github.com/jcmvbkbc/xtensa-toolchain-build/raw/
> >   BR2_PACKAGE_HOST_ELF2FLT=y
> >   # BR2_USE_MMU is not set
> > +# Use minimal busybox with hush and networking tools
> > +BR2_PACKAGE_BUSYBOX_CONFIG="package/busybox/busybox-minimal.config"
> > +
> >   # System
> >   BR2_SYSTEM_DHCP="eth0"
> >   BR2_TARGET_GENERIC_GETTY_PORT="ttyS0"
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot