Re: [Buildroot] [PATCH v2 2/2] package/elf2flt: fix fatal error regression on m68k, xtensa, riscv64

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Thu, Sep 15, 2022 at 09:21:52AM +0200, Peter Korsgaard wrote:
> >>>>> "Niklas" == Niklas Cassel via buildroot <buildroot@buildroot.org> writes:
> 
>  > This series fixes a fatal error at link time on m68k, xtensa,
>  > and riscv64, caused by a bad upstream elf2flt commit.
> 
>  > Without this patch, m68k, xtensa, and riscv64 would result in
>  > a fatal error:
>  > ERROR: text=0x3bab8 overlaps data=0x33f60 ?
> 
>  > With this patch, qemu_m68k_mcf5208_defconfig,
>  > qemu_riscv64_nommu_virt_defconfig, and
>  > qemu_xtensa_lx60_nommu_defconfig builds properly.
> 
>  > riscv64 and m68k boots to login prompt.
>  > xtensa crashes when loading init, the same behavior as when
>  > reverting the bad upstream elf2flt commit completely.
> 
>  > Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>

Hello Peter,

> 
> When was this regression introduced? With the update to elf2flt 2021.08?

While I didn't include the SHA1 in the buildroot patch,
the SHA1 is included in the elf2flt patch embedded in the
buildroot patch.

ba379d08bb78 ("elf2flt: fix for segfault on some ARM ELFs")

$ git tag --contains ba379d08bb78
v2021.08

So yes, the regression was introduced with elf2flt 2021.08.

> Are 2022.02.x and 2022.05.x also affected?

Buildroot branches 2022.02.x and 2022.05.x both includes
the patch the upgrades elf2flt to 2021.08, so these branches
should also be affected.

I've tried to upstream my patches to elf2flt:
https://github.com/uclinux-dev/elf2flt/pull/24

But maintainer seems to have gone AWOL :)


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot