Re: [Buildroot] [PATCH] toolchain: follow symlinks in ld.*so.* install helper

From: Sergey Matyukevich <geomatsi@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Romain Naour <romain.naour@gmail.com>
Subject: Re: [Buildroot] [PATCH] toolchain: follow symlinks in ld.*so.* install helper
Date: Sun, 8 Dec 2024 23:06:03 +0300	[thread overview]
Message-ID: <Z1X8K8PKSj-QZxF5@curiosity> (raw)
In-Reply-To: <20241207214732.69709f7f@windsurf>

Hi Thomas,

On Sat, Dec 07, 2024 at 09:47:32PM +0100, Thomas Petazzoni wrote:
> Hello Sergey,
> 
> On Sat,  7 Dec 2024 23:36:26 +0300
> Sergey Matyukevich <geomatsi@gmail.com> wrote:
> 
> > Current toolchain install helper fails to setup external toolchains with
> > merged-usr sysroot. It does not follow lib symlinks when looking for
> > ld.*.so.* files. As a result builds fail with various linker errors.
> > Follow symlinks in find tool when installing ld*.so.* linker scripts
> > from external toolchain directory to staging and target directories.
> > 
> > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> 
> Thanks for the patch!
> 
> I need to get back to my backlog, but I believe I had investigated some
> toolchain issue, and came back to the same patch/change as you.
> 
> This regression was introduced by commit
> 92207bc03f2358b28e0fd2cc3a41e40504b5d3d4 ("toolchain: handle toolchains
> with multiple ld*.so.* files").
> 
> I am wondering how I got to debug this? Are there some autobuilder
> issues?

I didn't see any autobuilder issues. Actually I was working with a 3rd
party vendor toolchain. Thanks for finding the commit that introduced
the regression. That commit enabled the use of multilib toolchains with
multiple ld*.so.* files. It turned out that my toolchain had both
properties:
- multilib with multiple ld*.so.* files
- merged-usr property

BTW, I did the following quick test. I baked a Buildroot merged-usr SDK
for aarch64 starting from qemu_aarch64_virt_defconfig. That SDK had a
single ld*.so.* file. Then I rebuilt qemu_aarch64_virt_defconfig image
using that SDK w/o my patch and w/o any issues. So indeed, we have to
use multilib _and_ merged-usr toolchain to trigger this symlink issue.

Should I resend v2 with 'Fixes' tag ?

Regards,
Sergey
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot