Re: [Buildroot] [PATCH] package/pkg-generic: store reall version in legal manifest

[yann.morin@orange.com]

Luca, All,

On 2025-01-21 19:10 +0100, Luca Ceresoli spake thusly:
> On Tue, 21 Jan 2025 17:16:37 +0100
> yann.morin@orange.com wrote:
> > On 2025-01-21 16:55 +0100, Luca Ceresoli spake thusly:
> > > On Tue, 21 Jan 2025 11:45:32 +0100
> > > <yann.morin@orange.com> wrote:  
[--SNIP--]
> > > It would be nice to shot an actual example in the commit message. I did
> > > a very quick search and couldn't find any package where the problem
> > > happens.  
[--SNIP--]
> > Finally, private packages (used from a br2-external tree) may have such
> > tags as well..
> Sure, make sense. If it were me, I'd add an example with one of those
> packages for which one can specify the version in a configuration
> setting, like U-Boot or Linux, in case you send a v2.

Sorry, maybe I was not clear about linux and uboot: they were just given
as an example where a slash could snick in; I don't know of any publicly
accessible git repositories that has such tags for those pacakges. There
is however Apache's ant that does have such tags (although it is not
(yet) pacjaged in Buildroot).

I'll send a v2 with a rewording of my previous explanations.

Thanks!

[--SNIP--]
> > > Not strictly specific about your patch, but IMO reusing the _DL_VERSION
> > > variable makes code less readable. [--SNIP--]
> > Vast subject. [--SNIP--]

Ah, I think I remember some details now: the consensus was not about
renaming _DL_VERSION, but getting rid of it, stop mangling _VERSION and
keep it untouched, and instead introduce _VERSION_SANITISED (or
whatev'). That was causing issues of which the details still evade me
for now...

> I hereby forget about having suggest such an improvement. O:-)

No worries, that was already something that was indeed discussed because
_DL_VERSION is indeed ugly; it specifically prevents having things like
an actual version as advertised upstream (which can get tracked by
releasemonitoring.org), vs. the tag in git that often gets a 'v' prefix
(or in the Apache ant case, a whole 'rel/' prefix). Hic sunt dracones.

Regards,
Yann E. MORIN.

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot