Re: [Buildroot] [PATCH v3 2/3] board/raspberrypi: allow non-matching globs for DTBs

From: Niklas Cassel via buildroot <buildroot@buildroot.org>
To: Fiona Klute <fiona.klute@gmx.de>, Romain Naour <romain.naour@smile.fr>
Cc: "buildroot@buildroot.org" <buildroot@buildroot.org>,
	"Gaël PORTAY" <gael.portay+rtone@gmail.com>,
	"Julien Grossholtz" <julien.grossholtz@openest.io>,
	"Martin Bark" <martin@barkynet.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	"José Mendes" <jp.baltazar.mendes@gmail.com>
Subject: Re: [Buildroot] [PATCH v3 2/3] board/raspberrypi: allow non-matching globs for DTBs
Date: Mon, 10 Feb 2025 12:47:20 +0000	[thread overview]
Message-ID: <Z6n1V0BQyoJjbn4u@ryzen> (raw)
In-Reply-To: <20250207171458.1127620-3-fiona.klute@gmx.de>

Hello Fiona,

On Fri, Feb 07, 2025 at 06:14:57PM +0100, Fiona Klute via buildroot wrote:
> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
> 
> When installing DTBs from the rpi-firmware package
> (BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS=y), there's no DTB directly in
> the images directory because the kernel build doesn't provide one.

Your new defconfig does not seem to have BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
set. What am I missing?

Regardless, perhaps clarify/rephrase your commit message.

> 
> Using pre-compiled DTBs is discouraged, but useful for using mainline
> kernels until suitable DTS can be merged, or to provide U-Boot with a
> DTB (via the firmware bootloader) independent of whatever kernel DTB
> is in use.

I don't really understand which pre-compiled DTB you are using, since
your series is not adding any DTB, and your defconfig does not have
BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS set.

However, wouldn't it be much better to rebase this series on either:

1) Romain's series:
https://lore.kernel.org/buildroot/20250204163622.192932-3-romain.naour@smile.fr/
which introduces BR2_LINUX_KERNEL_CUSTOM_DTS_PATH

or

2) Your own series:
https://lore.kernel.org/buildroot/20250207183455.1468220-1-fiona.klute@gmx.de/

Then this series could provide a DT source file (.dts) instead of a binary
blob (.dtb). Having a DTS file would make it easier for other buildroot
contributors to make changes, and once upstream has a DTS merged, you can
remove your DTS file provided by buildroot.

Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot