Re: [Buildroot] [PATCH 1/1] boot/uboot: fix binman failure

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Sat, Feb 08, 2025 at 06:21:15PM +0300, Sergey Matyukevich wrote:
> Hi Dario,
> 
> On Sat, Feb 08, 2025 at 12:12:03AM +0100, Dario Binacchi wrote:
> > The commit 4bce3270d680 ("Config.in: timeout earlier when connecting to
> > download servers"), among other things, adds the connection timeout
> > parameter to the default scp command:
> 
> ...
> 
> > Fixes: 4bce3270d680 ("Config.in: timeout earlier when connecting to download servers")
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > ---
> >  boot/uboot/uboot.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> > index 2796b0a31010..6bbdc4151fac 100644
> > --- a/boot/uboot/uboot.mk
> > +++ b/boot/uboot/uboot.mk
> > @@ -176,7 +176,8 @@ UBOOT_MAKE_OPTS += \
> >  	ARCH=$(UBOOT_ARCH) \
> >  	HOSTCC="$(HOSTCC) $(subst -I/,-isystem /,$(subst -I /,-isystem /,$(HOST_CFLAGS)))" \
> >  	HOSTLDFLAGS="$(HOST_LDFLAGS)" \
> > -	$(call qstrip,$(BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS))
> > +	$(call qstrip,$(BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS)) \
> > +	SCP=$(word 1, $(SCP))
> >  
> >  # Disable FDPIC if enabled by default in toolchain
> >  ifeq ($(BR2_BINFMT_FDPIC),y)
> > -- 
> > 2.43.0
> 
> Thanks for the fix ! I received several autobuild reports for OrangePi
> boards today and tested your fix for some of them. Here are the links:
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/9054932579
> https://gitlab.com/buildroot.org/buildroot/-/jobs/9054932525
> 
> Tested-by: Sergey Matyukevich <geomatsi@gmail.com>

Tested-by: Niklas Cassel <cassel@kernel.org>


Could this please be picked up?

The buildroot master branch currently fails to build without this patch.


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot