Re: [Buildroot] [PATCH 1/1] boot/uboot: support System Control Processor (SCP) firmware blob

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Tue, Feb 11, 2025 at 10:53:28AM +0100, Dario Binacchi wrote:
> > Hello Dario,
> >
> > here:
> > https://lore.kernel.org/buildroot/a023971c7c8bfa4826a9a8721500c7ff@free.fr/
> >
> > Julien said that it does not need to be /dev/null,
> > and that it works fine with just an empty string
> > (if the default is the empty string).
> >
> >
> > So, shouldn't you simply be able to remove the:
> >
> > BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"
> >
> > lines from the defconfigs, without any need to add any
> > BR2_TARGET_UBOOT_SCP_FIRMWARE="/dev/null"
> >
> > lines to the defconfigs?
> 
> Since I can't physically test the patch on the board, this way
> I'm sure that the modification is definitely backward compatible.
> This is the rationale I followed.

Considering that the problem is that the build fails if you don't have this,
there should be no need to physically test on the board.

You could simply build the defconfig for one of these boards:
$ make foo_defconfig && make
sha256sum the uboot binary.

Then apply your patch and:
$ make foo_defconfig && uboot-rebuild
then sha256sum the new uboot binary.

If the sha256sums match, I think you are good.

Personally, I think it would be cleaner if these defconfigs could drop
these lines, since they shouldn't be needed once your patch is applied.


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot