Re: [Buildroot] [PATCH v6 3/5] linux: introduce BR2_LINUX_KERNEL_CUSTOM_DTS_DIR

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Mon, Feb 24, 2025 at 09:50:19AM +0100, Niklas Cassel wrote:
> On Fri, Feb 21, 2025 at 11:55:27PM +0100, Romain Naour via buildroot wrote:
> > 
> > Note: We want to create a list of dts files (LINUX_DTS_LIST) present in
> > diectrories listed by BR2_LINUX_KERNEL_CUSTOM_DTS_DIR. But
> > LINUX_DTS_LIST must not contain BR2_LINUX_KERNEL_CUSTOM_DTS_DIR
> > paths. Use GNU 'find' print format %P to print each dts file path
> > without their respective dts overlay directory path.
> > Do the same for LINUX_DTSO_LIST.
> 
> Personally, I would drop this Note: from the commit message.
> 
> I think that your commit message is doing a really good job of explaining
> the problem (and the solution), but I don't think it needs implementation
> details like this in the commit message.
> 
> If you think this is important enough to keep, then it should probably be
> included as a comment next to the definition of LINUX_DTS_LIST instead of
> being in the commit message.
> 
> Regardless (if you chose to kill it, or to have it as a comment), I don't
> think you need to send a new version just for this, it could be fixed up
> while applying.
> 
> Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>

This series seems to have stalled.

Did you decide to wait for 2025.02 to get released before applying?


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot