Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Vincent Stehlé" <vincent.stehle@arm.com>
To: Niklas Cassel <niklas.cassel@wdc.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 0/3] misc aarch64-sbsa cleanups
Date: Mon, 6 Mar 2023 18:17:07 +0100	[thread overview]
Message-ID: <ZAYgE/KtpjD+PCby@debian> (raw)
In-Reply-To: <20230303122251.3392998-1-niklas.cassel@wdc.com>

On Fri, Mar 03, 2023 at 01:22:48PM +0100, Niklas Cassel wrote:
> Hello,
> 
> Here come some small aarch64-sbsa cleanups.
> Please consider for inclusion.
> 
> Changes since v1:
> -Modified test_edk2.py to use the same kernel config as
>  qemu_aarch64_sbsa_defconfig. (Thanks Vincent.)

Hi Niklas,

Thanks for fixing that.

I tested this v2 patch series on master and next: the
qemu_aarch64_sbsa_defconfig and the edk2 unit test work for me.

The edk2 unit test is slower due to the more complete kernel config and this
breaks the CI on gitlab. Maybe we should leave the reduced kernel config for the
unit test as it is after all? An alternative would be to extend the timeout,
somehow, but I don't know if unit tests longer than an hour are desirable.

Best regards,
Vincent.

> 
> 
> Kind regards,
> Niklas
> 
> 
> Niklas Cassel (3):
>   board/qemu/aarch64-sbsa: use PARTLABEL to specify root
>   board/qemu/aarch64-sbsa: use the default console specified by ACPI
>   support/testing: use the arch default kernel config in test_edk2.py
> 
>  board/qemu/aarch64-sbsa/grub.cfg        |  2 +-
>  board/qemu/aarch64-sbsa/linux.config    | 68 -------------------------
>  support/testing/tests/boot/test_edk2.py |  7 +--
>  3 files changed, 5 insertions(+), 72 deletions(-)
>  delete mode 100644 board/qemu/aarch64-sbsa/linux.config
> 
> -- 
> 2.39.2
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-03-06 17:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 12:22 [Buildroot] [PATCH v2 0/3] misc aarch64-sbsa cleanups Niklas Cassel via buildroot
2023-03-03 12:22 ` [Buildroot] [PATCH v2 1/3] board/qemu/aarch64-sbsa: use PARTLABEL to specify root Niklas Cassel via buildroot
2023-03-03 12:22 ` [Buildroot] [PATCH v2 2/3] board/qemu/aarch64-sbsa: use the default console specified by ACPI Niklas Cassel via buildroot
2023-03-03 12:22 ` [Buildroot] [PATCH v2 3/3] support/testing: use the arch default kernel config in test_edk2.py Niklas Cassel via buildroot
2023-03-06 17:17 ` Vincent Stehlé [this message]
2023-03-07  9:19   ` [Buildroot] [PATCH v2 0/3] misc aarch64-sbsa cleanups Niklas Cassel via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAYgE/KtpjD+PCby@debian \
    --to=vincent.stehle@arm.com \
    --cc=buildroot@buildroot.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=niklas.cassel@wdc.com \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox