Re: [Buildroot] [PATCH] add MMX instruction set capability for Geode CPU

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2451 bytes --]

On Thu, Jun 01, 2023 at 12:05:06AM +0900, AndreiCherniaev wrote:
> Signed-off-by: AndreiCherniaev <cherniaev.andrei@kairo.space>
> 
> Before this patch there is no way no enable MMX for Geode. Modern Geode CPU support MMX.
> This capability will interesting with ffmpeg for example.

The wordings here all look confusing to me.

I'd like to write the patch description as:

"Currently, there is no MMX support for GEODE processors in Buildroot.
Yet, some packages like ffmpeg leverage it when the package is built.

Add the instructions set support."

For the patch itself, see below.

> ---
>  arch/Config.in.x86 | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
> index c770ae3ffe..595db48d91 100644
> --- a/arch/Config.in.x86
> +++ b/arch/Config.in.x86
> @@ -521,11 +521,10 @@ config BR2_x86_steamroller
>  	select BR2_X86_CPU_HAS_SSE4
>  	select BR2_X86_CPU_HAS_SSE42
>  config BR2_x86_geode
> -	bool "geode"
> -	# Don't include MMX support because there several variant of geode
> -	# processor, some with MMX support, some without.
> -	# See: http://en.wikipedia.org/wiki/Geode_%28processor%29
> -	depends on !BR2_x86_64
> +        bool "geode"
> +        depends on !BR2_x86_64
> +        help
> +          see also BR2_x86_geode_with_MMX
>  config BR2_x86_c3
>  	bool "Via/Cyrix C3 (Samuel/Ezra cores)"
>  	depends on !BR2_x86_64
> @@ -633,5 +632,16 @@ config BR2_READELF_ARCH_NAME
>  	default "Intel 80386"			if BR2_i386
>  	default "Advanced Micro Devices X86-64" if BR2_x86_64
>  
> +config BR2_x86_geode_with_MMX
> +        bool "GEODE with MMX"
"MMX instructions support on GEODE"
> +        depends on BR2_x86_geode
> +        default n
> +        select BR2_X86_CPU_HAS_MMX
> +        help
> +          there several variant of geode processor,
> +          some with MMX support, some without.
> +          See: http://en.wikipedia.org/wiki/Geode_%28processor%29
> +          And decide can you use MMX or not
"Some variants of GEODE processor support MMX instructions set. Enable
this option if yours have that support. If unsure, see
https://en.wikipedia.org/wiki/Geode_%28processor%29 for features list
on GEODE processors."

Next time, time to brush up your grammar and spelling skills as well as
vocabulary.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot