Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Mukhin <alexander.i.mukhin@gmail.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: "José Luis Salvador Rufo" <salvador.joseluis@gmail.com>,
	"Michael Zimmermann" <sigmaepsilon92@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/zfs: fix cross-compilation
Date: Wed, 7 Jun 2023 15:43:53 +0300	[thread overview]
Message-ID: <ZIB7iXiZ-9GS4AU4@hs> (raw)
In-Reply-To: <20220724143533.GV2641@scaer>

Yann, All,

Noticed the same issue on x86-64 without cross-compiling. Here again the host
compiler was used instead of toolchain. The build failed because the host
compiler was older and did not support some fancy flags.

Host: Debian 11.7 x86_64
Host gcc: 10.2.1
Toolchain: x86-64--glibc--bleeding-edge-2022.08-1
Toolchain gcc: 12.2.0

The patch proposed by Michael Zimmermann fixed the issue.

-- 
Alexander.

On Sun, Jul 24, 2022 at 04:35:33PM +0200, Yann E. MORIN wrote:
> Michael, All,
> 
> On 2022-07-23 15:41 +0200, Arnout Vandecappelle spake thusly:
> > On 23/07/2022 14:42, Arnout Vandecappelle wrote:
> > >On 20/07/2022 17:24, Michael Zimmermann wrote:
> > >>Currently, the kernel module gets built using the host-compiler(from the
> > >>user distro, not from buildroot).
> >  It's actually easy to reproduce, just change the architecture to anything
> > other than x86.
> > 
> >  I've looked around a bit and it seems to me that zfs already builds the
> > kernel module from the autotools infrastructure, so we're actually building
> > it twice.
> 
> I checked, and it is not possible to tell the zfs buildsystem to not
> build it.
> 
> > I think we should therefore remove the kernel-module infra for
> > this package, and instead add a dependency on linux and copy this part:
> > 
> > # If the package is enabled, ensure the kernel will support modules
> > ifeq ($$(BR2_PACKAGE_$(2)),y)
> > LINUX_NEEDS_MODULES = y
> > endif
> 
> ... and add linux to ZFS_DEPDENDENCIES
> 
> So, I've marked the patch as changes requested in patchwork.
> 
> Regards,
> Yann E. MORIN.
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-06-07 12:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 15:24 [Buildroot] [PATCH 1/1] package/zfs: fix cross-compilation Michael Zimmermann
2022-07-23 12:42 ` Arnout Vandecappelle
2022-07-23 13:41   ` Arnout Vandecappelle
2022-07-24 14:35     ` Yann E. MORIN
2023-06-07 12:43       ` Alexander Mukhin [this message]
2023-06-08 17:50       ` [Buildroot] [PATCH] package/zfs: not using kernel-module infra José Luis Salvador Rufo
2023-07-27  7:13         ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZIB7iXiZ-9GS4AU4@hs \
    --to=alexander.i.mukhin@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=salvador.joseluis@gmail.com \
    --cc=sigmaepsilon92@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox