Re: [Buildroot] [PATCH] package/elf2flt: Fix build by updating to v2023.04

[Niklas Cassel via buildroot <buildroot@buildroot.org>]

On Sun, Aug 20, 2023 at 11:49:26PM +0200, Thomas Petazzoni wrote:
> Hello Jesse,
> 
> On Fri, 18 Aug 2023 23:08:49 -0400
> Jesse Taube <mr.bossman075@gmail.com> wrote:
> 
> > In elf2flt Greg Ungerer committed "elf2flt: remove use of BFD_VMA_FMT":
> > 
> > "In binutils-2.40 the BFD_VMA_FMT definition used for printf style
> > formatting specifiers has been removed. For reference this was done in
> > commit b82817674f46 ("Don't use BFD_VMA_FMT in binutils") in the
> > binutils git development tree.
> > 
> > BFD_VMA_FMT is used in a number of places in the elf2flt code to output
> > bfd offsets, values and the like. So it is broken when using the bfd
> > code from binutils-2.40 and newer.
> > 
> > According to the binutils change PRIx64 (and friends) is used to replace
> > it, with appropriate casts to keep it clean for 32 and 64 bit platforms.
> > Change the elf2flt.c use of it in the same way to fix."
> > 
> > This patch updates elf2flt to version v2023.04, and rebases all the
> > Buildroot patches.
> > 
> > Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> 
> Could you clarify which build failure this is fixing? The commit title
> says "fix build" but you don't explain which build failure is being
> fixed.
> 
> If it's the BFD_VMA_FMT issue, it has already been fixed by commit
> https://gitlab.com/buildroot.org/buildroot/-/commit/d79f9c9f416ac5da90cd428916cff0b5288cb03a
> in which we have backported the upstream commit you're referring to.
> 
> That being said, bumping the version of elf2flt is certainly a good
> idea moving forward. However, we should be careful when doing this, as
> updating elf2flt has several times in the past proven to come with a
> number of regressions.

If you can build and boot test:
riscv64, xtensa, and m68k then I'm very much in favor of a bump!

(Personally, I have kind of given up hope of upstream elf2flt,
but it's nice to see some activity after almost 2 years of some
of these issues being known and having open pull requests.
Now if they would merge the riscv patches, then I would be even
more surprised :p)

For riscv you can boot test using the defconfig:
qemu_riscv64_nommu_virt_defconfig

Unfortunately, I don't remember which defconfig I used to test m68k and
xtensa.

I do remember that Thomas reported a build error that was only seen when
explictly enabling BR2_PACKAGE_GDB, so it would be nice if you could enable
that as well. (It wasn't enabled by default in some of the defconfigs.)


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot