Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Waldemar Brodkorb <wbx@openadk.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] package/gmp: fix compile error for riscv
Date: Wed, 23 Aug 2023 10:39:31 +0200	[thread overview]
Message-ID: <ZOXFw5o17WS9rg8n@waldemar-brodkorb.de> (raw)
In-Reply-To: <20230822180900.6953F86114@busybox.osuosl.org>

Hi Thomas,
Thomas Petazzoni via buildroot wrote,

> commit: https://git.buildroot.net/buildroot/commit/?id=6d8deb4b23ee57a69308bcdc5ceafa02aacc1edd
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> In commit 87b2a30319394c2cc79efae1af7833cad8c62b32 gmp got updated
> to 6.2.1, since then the compile error exist.
> 
> Compile error looks like this:
> tmp-mul_1.s: Assembler messages:
> tmp-mul_1.s:55: Error: unrecognized opcode `mul a5,a7,a3'
> tmp-mul_1.s:57: Error: unrecognized opcode `mulhu a7,a7,a3'
> 
> Patch should be backported to stable branches.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/2f2/2f2112bea73adbf49eabb62fe6cda6a9cd5d0567
>  - http://autobuild.buildroot.net/results/566/566a4945555b781ed127997176f73b3c17ecab5d
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/gmp/gmp.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/gmp/gmp.mk b/package/gmp/gmp.mk
> index 9b402767fd..3b732dfa71 100644
> --- a/package/gmp/gmp.mk
> +++ b/package/gmp/gmp.mk
> @@ -23,6 +23,11 @@ ifeq ($(BR2_m68k_cf)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6)$(BR2_ARM_CP
>  GMP_CONF_OPTS += --disable-assembly
>  endif

 I think we need to guard it with BR2_riscv or not?
  
> +# GMP needs M extension for riscv assembly
> +ifeq ($(BR2_RISCV_ISA_CUSTOM_RVM),)
> +GMP_CONF_OPTS += --disable-assembly
> +endif

best regards
 Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-23  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 18:08 [Buildroot] [git commit] package/gmp: fix compile error for riscv Thomas Petazzoni via buildroot
2023-08-23  8:39 ` Waldemar Brodkorb [this message]
2023-08-23 20:45   ` Thomas Petazzoni via buildroot
2023-08-24  5:03     ` Waldemar Brodkorb
  -- strict thread matches above, loose matches on Subject: below --
2023-08-22 18:08 Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOXFw5o17WS9rg8n@waldemar-brodkorb.de \
    --to=wbx@openadk.org \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox