Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Julien Olivain <ju.o@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/criu: new package
Date: Sun, 10 Sep 2023 21:41:58 +0200	[thread overview]
Message-ID: <ZP4cBkx2VFsfsN7M@gmail.com> (raw)
In-Reply-To: <35d775ed8e08f7082c025d0c32f53bb4@free.fr>


[-- Attachment #1.1: Type: text/plain, Size: 1213 bytes --]

Hi Julien,

On Sat, Sep 09, 2023 at 11:16:27PM +0200, Julien Olivain wrote:
> Hi Thomas, Marcus,
> 
> On 09/09/2023 15:55, Thomas Petazzoni wrote:
> > On Sat, 9 Sep 2023 15:03:13 +0200
> > Marcus Folkesson <marcus.folkesson@gmail.com> wrote:
> > 
> > > Thank you for your solid review.
> 
> [...]
> 
> > One good thing would be to have a runtime test for criu, in
> > support/testing. Julien Olivain (in Cc) can probably provide some
> > guidance here.
> 
> 
> Marcus, you should be able to reproduce that with the command:
> 
>     utils/test-pkg -p criu

I've sent out a v2 where the comments from Thomas is addressed. But I am
not able to reproduce the errors you got with test-pkg.

I'm not sure why it skips my tests. Could you please provide some
guidance?

> 
> Ideally, the package should have no failure (i.e. only OK or SKIPPED)
> when testing all toolchains, with:
> 
>     utils/test-pkg -a -p criu
> 
> Then, you should be able to see the end of build logs with:
> 
>     tail ~/br-test-pkg/*/logfile
> 
> For the details, see:
> https://nightly.buildroot.org/manual.html#testing-package
> 
> Best regards,
> 
> Julien.


Best regards
Marcus Folkesson

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-09-10 19:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08  8:27 [Buildroot] [PATCH 1/2] package/criu: new package Marcus Folkesson
2023-09-08  8:27 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add Marcus Folkesson for package/criu Marcus Folkesson
2023-09-08 20:46   ` Thomas Petazzoni via buildroot
2023-09-08 20:57 ` [Buildroot] [PATCH 1/2] package/criu: new package Thomas Petazzoni via buildroot
2023-09-09 13:03   ` Marcus Folkesson
2023-09-09 13:55     ` Thomas Petazzoni via buildroot
2023-09-09 21:16       ` Julien Olivain
2023-09-10 19:41         ` Marcus Folkesson [this message]
2023-09-10 21:05           ` Julien Olivain
2023-09-12 12:53             ` Marcus Folkesson
2023-09-12 13:17               ` Thomas Petazzoni via buildroot
2023-09-12 21:53               ` Julien Olivain
2023-09-13  5:56                 ` Marcus Folkesson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZP4cBkx2VFsfsN7M@gmail.com \
    --to=marcus.folkesson@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox