Hi Julian,

On Fri, Oct 06, 2023 at 10:35:14PM +0200, Julien Olivain wrote:
> Hi Marcus,
> 
> On 06/10/2023 13:46, Marcus Folkesson wrote:
> > Julien, do you have the posibility to run test-pkg on this patch?
> > 
> > I still get wierd errors (related to host-libzlib (?) ) for the
> > bootlin-armv7-glibc toolchain.
> 
> I ran a test-pkg on this v3 patch. I am not able to reproduce this
> host-libzlib failure (both on my host system and in the reference
> utils/docker-run Docker image). But I do see a build failure with
> the bootlin-armv7-glibc toolchain in the criu package:
> 
>     cat > criu.config <<EOF
>     BR2_PACKAGE_HOST_PYTHON3=y
>     BR2_PACKAGE_CRIU=y
>     EOF
> 
>     utils/test-pkg -c criu.config -p criu
>         bootlin-armv5-uclibc [1/6]: SKIPPED
>          bootlin-armv7-glibc [2/6]: FAILED
>        bootlin-armv7m-uclibc [3/6]: SKIPPED
>          bootlin-x86-64-musl [4/6]: OK
>           br-arm-full-static [5/6]: SKIPPED
>                 sourcery-arm [6/6]: SKIPPED
>     6 builds, 4 skipped, 1 build failed, 0 legal-info failed, 0 show-info
> failed
> 
> It fails with output:
> 
>     /home/br-user/br-test-pkg/bootlin-armv7-glibc/host/bin/arm-linux-ld:
> ./compel/plugins/std.lib.a(string.o): in function `std_vdprintf':
>     string.c:(.text+0x114): undefined reference to `__aeabi_idivmod'
> 
> Maybe the SUBARCH make variable need to be set for Arm, because the
> criu Makefile adjust few flags based on its value. See [1].

Thank you for testing, it is highly appreciated.

I will try to build using the docker image as I'm only getting problem
with host-libzlib, even for a clean build.

I will add this for the next patch version

ifeq ($(BR2_ARM_CPU_ARMV6), y)
CRIU_MAKE_ENV += SUBARCH=armv6
else ifeq ($(BR2_ARM_CPU_ARMV7A), y)
CRIU_MAKE_ENV += SUBARCH=armv7
else ifeq ($(BR2_ARM_CPU_ARMV7M), y)
CRIU_MAKE_ENV += SUBARCH=armv7
else ifeq ($(BR2_ARM_CPU_ARMV8A), y)
CRIU_MAKE_ENV += SUBARCH=armv8
else ifeq ($(BR2_ARM_CPU_ARMV8M), y)
CRIU_MAKE_ENV += SUBARCH=armv8
endif

But the Makefile defaults to armv7, so I do not think it make any
difference for bootlin-armv7-glibc.

> 
> > 
> > bootlin-x86-64-musl is 'OK' though.
> > 
> > Thanks,
> > Marcus
> 
> Best regards,
> 
> Julien.
> 
> [1] https://github.com/checkpoint-restore/criu/blob/v3.18/Makefile#L35


/Marcus