From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/testing: test_python_ml_dtypes: remove BR2_PACKAGE_PYTHON3_ZLIB
Date: Fri, 29 Dec 2023 21:50:06 +0100 [thread overview]
Message-ID: <ZY8w_seALD034sVV@landeda> (raw)
In-Reply-To: <20231229145025.237058-1-ju.o@free.fr>
Julien, All,
On 2023-12-29 15:50 +0100, Julien Olivain spake thusly:
> The test_python_ml_dtypes.py enabled BR2_PACKAGE_PYTHON3_ZLIB=y in its
> configuration to workaround the fact that the toolchain used to
> testing was tainted with zlib.
>
> The commit 7e0e6e3
> "toolchain/toolchain-external/toolchain-external-bootlin: update to
> 2023.11-1" updated the toolchains which are no longer tainted with
> zlib.
>
> The workaround is no longer needed and this commit removes this
> config, for consistency.
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Patch tested on branch master at commit 7e0e6e3 with commands:
>
> make check-package
> ...
> 0 warnings generated
>
> support/testing/run-tests \
> -d dl -o output_folder \
> tests.package.test_python_ml_dtypes
> ...
> OK
> ---
> support/testing/tests/package/test_python_ml_dtypes.py | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/support/testing/tests/package/test_python_ml_dtypes.py b/support/testing/tests/package/test_python_ml_dtypes.py
> index 8d2369576b..8367107247 100644
> --- a/support/testing/tests/package/test_python_ml_dtypes.py
> +++ b/support/testing/tests/package/test_python_ml_dtypes.py
> @@ -4,16 +4,9 @@ from tests.package.test_python import TestPythonPackageBase
> class TestPythonPy3MlDtypes(TestPythonPackageBase):
> __test__ = True
>
> - # Note: BR2_PACKAGE_PYTHON3_ZLIB=y is needed as a runtime
> - # dependency because the Bootlin toolchain used for this test is
> - # tainted with zlib (and gets detected by python3/numpy).
> - # See commit 8ce33fed "package/gdb: gdbserver does not need zlib".
> - # This config entry can be removed as soon as the toolchain is
> - # updated without zlib in its sysroot.
> config = TestPythonPackageBase.config + \
> """
> BR2_PACKAGE_PYTHON3=y
> - BR2_PACKAGE_PYTHON3_ZLIB=y
> BR2_PACKAGE_PYTHON_ML_DTYPES=y
> """
> sample_scripts = ["tests/package/sample_python_ml_dtypes.py"]
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-12-29 20:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 14:50 [Buildroot] [PATCH 1/1] support/testing: test_python_ml_dtypes: remove BR2_PACKAGE_PYTHON3_ZLIB Julien Olivain
2023-12-29 20:50 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZY8w_seALD034sVV@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox