Re: [Buildroot] [PATCH v4 02/10] package/dmenu-wayland: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

On 2023-12-21 08:36 -0700, Adam Duskett spake thusly:
> This package is an alternative to dmenu for X.

I scratched my head around that one, because it is ambiguous: why is it
named dmenu-*wayland* if it is for X? OK, so it's the other way around:
dmenu is for X (only); dmenu is another implementation of dmenu, for
wayland. I rewrote the sentence to avoid the ambiguity (at least I find
the new wording less ambiguous).

> Sway uses it by default as its
> menu bar.
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
[--SNIP--]
> diff --git a/package/dmenu-wayland/Config.in b/package/dmenu-wayland/Config.in
> new file mode 100644
> index 0000000000..e2af09080c
> --- /dev/null
> +++ b/package/dmenu-wayland/Config.in
> @@ -0,0 +1,26 @@
> +config BR2_PACKAGE_DMENU_WAYLAND
> +	bool "dmenu-wayland"
> +	depends on BR2_USE_MMU # pango
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # pango, wayland

Threqds also inherited because of libglib2.

> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango
> +	depends on !BR2_STATIC_LIBS # wayland
> +	depends on BR2_INSTALL_LIBSTDCPP # pango
> +	depends on BR2_USE_WCHAR # pango

Ditto wchar.

[--SNIP--]
> +comment "dmenu-wayland needs a toolchain w/ wchar, threads, C++, dynamic library, gcc >= 4.9"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_TOOLCHAIN_HAS_THREADS || \

I see that the naming of the variable is not obvious, and that the
manual is a bit ambiguous about it, but BR2_TOOLCHAIN_HAS_SYNC_4 is an
architecture dependency. As such, it should be used ti hide the comment,
like MMU.

I've fixed all these minor issues and applied to master, thanks.

Regards,
Yann E. MORIN.

> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || BR2_STATIC_LIBS || \
> +		!BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
> diff --git a/package/dmenu-wayland/dmenu-wayland.hash b/package/dmenu-wayland/dmenu-wayland.hash
> new file mode 100644
> index 0000000000..1248c4ad66
> --- /dev/null
> +++ b/package/dmenu-wayland/dmenu-wayland.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256  56340e198a2c58468c6109f3bb07ab8a074487e67b0758b29c9d4fdce7c4d594  dmenu-wayland-a380201dff5bfac2dace553d7eaedb6cea6855f9.tar.gz
> +sha256  8d26bccf8a21c5e29dc756beef534403c935766c815bbb6e7eab0598632b9827  LICENSE
> diff --git a/package/dmenu-wayland/dmenu-wayland.mk b/package/dmenu-wayland/dmenu-wayland.mk
> new file mode 100644
> index 0000000000..33a73c0153
> --- /dev/null
> +++ b/package/dmenu-wayland/dmenu-wayland.mk
> @@ -0,0 +1,28 @@
> +################################################################################
> +#
> +# dmenu-wayland
> +#
> +################################################################################
> +
> +DMENU_WAYLAND_VERSION = a380201dff5bfac2dace553d7eaedb6cea6855f9
> +DMENU_WAYLAND_SITE = $(call github,nyyManni,dmenu-wayland,$(DMENU_WAYLAND_VERSION))
> +DMENU_WAYLAND_LICENSE = MIT
> +DMENU_WAYLAND_LICENSE_FILES = LICENSE
> +
> +# host-wayland is for wayland-scanner
> +DMENU_WAYLAND_DEPENDENCIES = \
> +	host-wayland \
> +	cairo \
> +	libglib2 \
> +	libxkbcommon \
> +	pango \
> +	wayland \
> +	wayland-protocols
> +
> +# By default, sway calls dmenu not dmenu-wl
> +define DMENU_WAYLAND_SYMLINK_DMENU_WL
> +	ln -sf dmenu-wl $(TARGET_DIR)/usr/bin/dmenu
> +endef
> +DMENU_WAYLAND_POST_INSTALL_TARGET_HOOKS += DMENU_WAYLAND_SYMLINK_DMENU_WL
> +
> +$(eval $(meson-package))
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot