From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] package/gdb: add support for GDB 14.1
Date: Wed, 27 Dec 2023 22:40:35 +0100 [thread overview]
Message-ID: <ZYyZ0y4be97YCUee@landeda> (raw)
In-Reply-To: <20231224160831.871650-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2023-12-24 17:08 +0100, Thomas Petazzoni via buildroot spake thusly:
> All patches are still relevant, and have been rebased on top of GDB
> 14.1.
>
> GDB 14.1 now needs mpfr unconditionally, so it is added as a
> dependency of host-gdb, and of gdb when the full debugger is built.
[--SNIP--]
> diff --git a/package/gdb/Config.in b/package/gdb/Config.in
> index e4ab39a2bd..7251dce668 100644
> --- a/package/gdb/Config.in
> +++ b/package/gdb/Config.in
> @@ -59,6 +59,7 @@ config BR2_PACKAGE_GDB_DEBUGGER
> depends on BR2_USE_WCHAR
> depends on !BR2_sh
> select BR2_PACKAGE_GMP if !BR2_arc
> + select BR2_PACKAGE_MPFR if BR2_GDB_VERSION_14
This is a bit fragile: when we add gdb 15, and drop gdb 12, gdb 14 will
become the default version. Then, if the host variant is not selected,
BR2_GDB_VERSION_14 will not be set. If the user enables the full gdb n
target, mpfr will not be selected.
I've added a litle blurb in the config.in.host, pointing to this part of
the code for an appropriate update.
Applied to master, thanks.
Alternatively, I wonder if we shouldn't jsut make mpfr unconditional for
all versions of gdb, now.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-12-27 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 16:08 [Buildroot] [PATCH 1/3] package/gdb: add support for GDB 14.1 Thomas Petazzoni via buildroot
2023-12-24 16:08 ` [Buildroot] [PATCH 2/3] package/gdb: make GDB 13.x the default version Thomas Petazzoni via buildroot
2023-12-24 16:08 ` [Buildroot] [PATCH 3/3] package/gdb: remove support for GDB 11.x Thomas Petazzoni via buildroot
2023-12-27 21:40 ` Yann E. MORIN [this message]
2024-01-02 8:32 ` [Buildroot] [PATCH 1/3] package/gdb: add support for GDB 14.1 Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYyZ0y4be97YCUee@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox