From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [git commit] package/qt6base: remove $(TARGET_DIR)/usr/mkspecs in target-finalize
Date: Wed, 10 Jan 2024 21:11:22 +0100 [thread overview]
Message-ID: <ZZ756kxkevit-FJz@landeda> (raw)
In-Reply-To: <87edepasjd.fsf@48ers.dk>
Peter, All,
On 2024-01-10 20:37 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> > qt6base installs things in /usr/mkspecs, but also the soon to be added
> > qt6core5compat, and the existing package qwt as well.
[--SNIP--]
> > diff --git a/package/qwt/qwt.mk b/package/qwt/qwt.mk
> > index 9f0b78655f..f344ca4e3a 100644
> > --- a/package/qwt/qwt.mk
> > +++ b/package/qwt/qwt.mk
> > @@ -58,7 +58,6 @@ endef
>
> > define QWT_INSTALL_TARGET_CMDS
> > $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install INSTALL_ROOT=$(TARGET_DIR)
> > - rm -Rf $(TARGET_DIR)/usr/mkspecs
> Hmm, qwt is a qt5 package, so this looks odd?
Ah, indeed, I didn't realise that. The original was a hard-coded removal
of $(TARGET_DIR)/usr/mkspecs, so that would have indeed taken care of
the removal for qwt, qt6base and any other qt6 package.
However, I changed it to a qt6base target-finalize hook when aplying,
and I did not realise qwt was not a qt6 package.
For Qt6, the /usr/mkspec is really a qt6base thing, so I still believe
it makes sense that it is a qt6base target-fionalize hook. For qwt, this
is an issue specific to qwt, not qt5base, so it makes sense to keep it
as an ad-goc fixup.
I'll revert the qwt part.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-01-10 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 20:31 [Buildroot] [git commit] package/qt6base: remove $(TARGET_DIR)/usr/mkspecs in target-finalize Yann E. MORIN
2024-01-10 19:37 ` Peter Korsgaard
2024-01-10 20:11 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ756kxkevit-FJz@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox