Re: [Buildroot] [PATCH v6] package/ivi-homescreen: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

ADam, All,

On 2024-01-06 16:01 -0700, Adam Duskett spake thusly:
> Much like flutter-pi, this package is a Flutter embedder used to run Flutter
> applications. However, unlike Flutter-pi, this package requires a Wayland
> compositor to run, which flutter-pi does not support. Furthermore, flutter-pi
> lacks several plugins and features that ivi-homescreen supports, such as:
[--SNIP--]
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
[--SNIP--]
> diff --git a/package/ivi-homescreen/Config.in b/package/ivi-homescreen/Config.in
> new file mode 100644
> index 0000000000..c59ff09a51
> --- /dev/null
> +++ b/package/ivi-homescreen/Config.in
> @@ -0,0 +1,268 @@
> +menuconfig BR2_PACKAGE_IVI_HOMESCREEN
> +	bool "ivi-homescreen"
> +	depends on BR2_PACKAGE_HOST_FLUTTER_SDK_BIN_ARCH_SUPPORTS

That dependency was missing on the comments, so I propagated there.

> +	depends on BR2_PACKAGE_FLUTTER_ENGINE_ARCH_SUPPORTS
> +	depends on BR2_TOOLCHAIN_USES_GLIBC # flutter-engine
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # flutter-engine
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # # flutter-engine
> +	depends on BR2_INSTALL_LIBSTDCPP # flutter-engine
> +	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # flutter-engine
> +	depends on !BR2_STATIC_LIBS # flutter-engine, wayland
> +	depends on BR2_USE_WCHAR # flutter-engine
> +	depends on BR2_HOST_GCC_AT_LEAST_5 # flutter-engine

I've reordered the dependency in a more logical way (like host gcc-5 and
target gcc-5 together).

I also dropped the NPTL requirement, as it is implied by glibc. I see
that you did propagate the dependency from flutter-engine, but it needs
to be fixed there as well (I missed that when applying flutter-engine).

[--SNIP--]
> +config BR2_PACKAGE_IVI_HOMESCREEN_IVI_SHELL_CLIENT
> +	bool "ivi-shell client"
> +	select BR2_PACKAGE_IVI_HOMESCREEN_HAS_CLIENT

    $ ./utils/docker-run make check-package
    package/ivi-homescreen/Config.in:37: BR2_PACKAGE_IVI_HOMESCREEN_HAS_CLIENT referenced but not defined

I guess that's because you initially followed ny suggestion on how to
handle the clients, but then changed your mind and dropped the options.
I fixed that when applying.

[--SNIP--]
> diff --git a/package/ivi-homescreen/ivi-homescreen.hash b/package/ivi-homescreen/ivi-homescreen.hash
> new file mode 100644
> index 0000000000..a0d0162948
> --- /dev/null
> +++ b/package/ivi-homescreen/ivi-homescreen.hash
> @@ -0,0 +1,21 @@
> +# Locally calculated
> +sha256  1ab2e7ab5f947482cb5529dbb6392e7e1945ceb0b593abde6b6279d7bd2fdb79  ivi-homescreen-5ab78a19e95c88cc5d6b173ab1260a211e78cf0a-br1.tar.gz
> +
> +# Apache-2.0
> +sha256  6b96fa0a3def85caaf466caa2bd82d4ca4f22d106ff88f97a00c537c00cc714b  LICENSE
> +sha256  943c358cb6d086e4bc0937941b8f8d766db7d4e5f06583efd45dca0ca6a645f3  third_party/filament/libs/bluevk/include/bluevk/BlueVK.h
> +
> +# BSD-3-Clause
> +sha256  fdff25c8a4147791114584a45d56621336d294601da77656e83504a71747c8c2  third_party/flutter/shell/platform/common/client_wrapper/core_implementations.cc
> +
> +# BSD-Style
> +sha256  baa98cbcc03e3e745c4ad9ac2d3fb3464424486b2e420081181013034a7e6406  third_party/flutter/third_party/dart/runtime/include/dart_api.h
> +
> +# BSL-1.0
> +sha256  c9bff75738922193e67fa726fa225535870d2aa1059f91452c411736284ad566  third_party/asio-1-28-1/asio/LICENSE_1_0.txt
> +
> +# MIT
> +sha256  240f786071b64c28c0a1dae3e3b05fc3ca93fa4882b1e36e56ee49fee3037b0a  third_party/flutter/third_party/rapidjson/include/rapidjson/rapidjson.h
> +sha256  4b67e7ae8c91e68e1a929eb1cbaa4c773c6d19aa91aaa12c390cf9560d1c9799  third_party/sanitizers-cmake/LICENSE
> +sha256  a7241a379cb98d37788f82c2fc2e484c3ae85dae881fd3406f0637644850926f  third_party/spdlog-1.12.0/LICENSE
> +sha256  8b79f17fa7cf47adeeb8277965267e3932155fdfcab81a0ed5d583438bdf9135  third_party/weston/protocol/ivi-application.xml

Good idea to group the licenses by category.

> diff --git a/package/ivi-homescreen/ivi-homescreen.mk b/package/ivi-homescreen/ivi-homescreen.mk
> new file mode 100644
> index 0000000000..1fe4f09f9e
> --- /dev/null
> +++ b/package/ivi-homescreen/ivi-homescreen.mk
> @@ -0,0 +1,135 @@
> +################################################################################
> +#
> +# ivi-homescreen
> +#
> +################################################################################
> +
> +IVI_HOMESCREEN_VERSION = 5ab78a19e95c88cc5d6b173ab1260a211e78cf0a
> +IVI_HOMESCREEN_SITE = https://github.com/toyota-connected/ivi-homescreen.git
> +IVI_HOMESCREEN_SITE_METHOD = git
> +IVI_HOMESCREEN_LICENSE = Apache-2.0, BSD-3-Clause, BSD-Style, BSL-1.0, MIT
> +
> +IVI_HOMESCREEN_LICENSE_FILES = \
> +	LICENSE \
> +	third_party/asio-1-28-1/asio/LICENSE_1_0.txt \
> +	third_party/filament/libs/bluevk/include/bluevk/BlueVK.h \
> +	third_party/flutter/shell/platform/common/client_wrapper/core_implementations.cc \
> +	third_party/flutter/third_party/dart/runtime/include/dart_api.h \
> +	third_party/flutter/third_party/rapidjson/include/rapidjson/rapidjson.h \
> +	third_party/sanitizers-cmake/LICENSE \
> +	third_party/spdlog-1.12.0/LICENSE \
> +	third_party/weston/protocol/ivi-application.xml

I fixed the order to match that of the hash file, and adding a little
comment stating so.

Applied to master with the minor nits above fixed, thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot