Re: [Buildroot] [PATCH 1/1] package/fcft: disable uClibc support

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Adam, All,

Thanks for this patch.

On 2024-01-03 10:26 -0700, Adam Duskett spake thusly:
> uClibc support does not include the threads.h header file that fcft.c includes
> on line 8.

As the actual issue has now been understood, I've amended the commit log
with the explanation.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Musl and GlibC, however, do include the threads header file. As such, it is
> only necessary to turn off support for uClibc. Furthermore, the only package
> that currently selects  BR2_PACKAGE_FCFT is BR2_PACKAGE_FOOT. This patch also
> updates the "foot" package to match the dependencies of BR2_PACKAGE_FCFT.
> 
> Also, update the comment for BR2_PACKAGE_FCFT and BR2_PACKAGE_FOOT to mention
> that a glibc of the musl toolchain is needed. The wording of the message
> borrows from the liquid-dsp package, with the word "required" being substituted
> for the word "needs" as the word "needs" already existed for the fifth and foot
> packages.
> 
> Fixes:
> http://autobuild.buildroot.net/results/1b2dda32a90d7db8117eede09f46d44cffe60993
> http://autobuild.buildroot.net/results/5f03bb5c0c107a2b908be974421ae0a032d4dd89
> http://autobuild.buildroot.net/results/31a1f022414a8a1888cac4a5cd1761257d0f2196
> http://autobuild.buildroot.net/results/4522781e0448b325b54e93bbfb20f8295ea7061d
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/fcft/Config.in | 4 +++-
>  package/foot/Config.in | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/package/fcft/Config.in b/package/fcft/Config.in
> index b65515a3f1..d6da101d51 100644
> --- a/package/fcft/Config.in
> +++ b/package/fcft/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_FCFT
>  	bool "fcft"
> +	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # threads.h
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_FONTCONFIG
>  	select BR2_PACKAGE_FREETYPE
> @@ -48,5 +49,6 @@ config BR2_PACKAGE_FCFT_SVG_SUPPORT
>  
>  endif # BR2_PACKAGE_FCFT
>  
> -comment "fcft needs a toolchain w/ threads"
> +comment "fcft needs a glibc or musl toolchain w/ threads"
> +	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/foot/Config.in b/package/foot/Config.in
> index 24b3f78821..a88766fca6 100644
> --- a/package/foot/Config.in
> +++ b/package/foot/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_FOOT
>  	bool "foot"
>  	depends on !BR2_STATIC_LIBS # wayland
> +	depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # fcft
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # fcft, wayland
>  	select BR2_PACKAGE_FCFT
>  	select BR2_PACKAGE_FONTCONFIG
> @@ -32,5 +33,6 @@ config BR2_PACKAGE_FOOT_THEMES
>  
>  endif # BR2_PACKAGE_FOOT
>  
> -comment "foot needs a toolchain w/ dynamic library, threads"
> +comment "foot needs a glibc or musl toolchain w/ dynamic library, threads"
> +	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot