From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Guillaume William Brs <guillaume.bressaix@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/liquid-dsp: fix build without neon
Date: Sun, 7 Jan 2024 17:54:47 +0100 [thread overview]
Message-ID: <ZZrXV0IzLjKOuvU7@landeda> (raw)
In-Reply-To: <CAPi7W82KB5bmo_+2C87CdS1kBy76UmMm0S1e0A2dg77ce1f1JQ@mail.gmail.com>
Fabrice, All,
On 2024-01-07 17:11 +0100, Fabrice Fontaine spake thusly:
> Le dim. 7 janv. 2024 à 16:48, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2024-01-07 14:23 +0100, Fabrice Fontaine spake thusly:
[--SNIP--]
> > > +ifeq ($(BR2_arm):$(BR2_ARM_FPU_NEON),y:)
> > > +LIQUID_DSP_CONF_OPTS += --enable-simdoverride
> > Usually, we add an explicit --disable. Any reason why it was not added
> > here?
> Because --disable-simdoverride is not supported, worst,
> --disable-simdoverride has the same effect than --enable-simdoverride,
> because upstream doesn't check the value provided by the user:
> https://github.com/jgaeddert/liquid-dsp/blob/5432e317e3c31f069e8223d185c28078fc41c8cc/configure.ac#L64
Ah, indeed, thanks. I also saw that the existing code did not add it,
now, so I've refactored the code to make it explicit why we do not pass
--disable-simdoverride, and I extended the commit log with an excerpt
from the configure.ac while at it.
Applied to master, thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-07 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-07 13:23 [Buildroot] [PATCH 1/1] package/liquid-dsp: fix build without neon Fabrice Fontaine
2024-01-07 15:48 ` Yann E. MORIN
2024-01-07 16:11 ` Fabrice Fontaine
2024-01-07 16:54 ` Yann E. MORIN [this message]
2024-01-13 13:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZrXV0IzLjKOuvU7@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=guillaume.bressaix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox