Re: [Buildroot] [PATCH 1/1] package/libtraceevent: needs dynamic library

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libtraceevent: needs dynamic library
Date: Mon, 8 Jan 2024 22:24:52 +0100	[thread overview]
Message-ID: <ZZxoJD28cEghbMB7@landeda> (raw)
In-Reply-To: <20240108204352.319621-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-01-08 21:43 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure raised since the addition of the package
> in commit 1474f1b34b178defca1d16d18a2446fadda9a12b:
> 
> ../src/event-plugin.c:10:10: fatal error: dlfcn.h: No such file or directory
>    10 | #include <dlfcn.h>
>       |          ^~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/7802d1ad00293147edda39683f6d3f614dd48263
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in
> index adfca4dbe3..62adae4463 100644
> --- a/package/linux-tools/Config.in
> +++ b/package/linux-tools/Config.in
> @@ -104,6 +104,7 @@ endif
>  
>  config BR2_PACKAGE_LINUX_TOOLS_RTLA
>  	bool "rtla"
> +	depends on !BR2_STATIC_LIBS # libtracefs -> libtraceevent

In the past, we used to indeed list the full dependency chain that
caused the inherited dependency.

However, there never a good reasoning behind that (unwritten) rule.

Recently, we've started to drop the full chain to only keep the
first-level inheritance.

Indeed, if one of the package further in the dependency chain loses that
dependency, but the first-level package keeps it, it's going to be
tricky to track and update all those comments.

So, I believe it is better to just list the first-level inheritance.

I think the new reasoning is more sound than the previous one.
That's still an unwritten rule, though... :-(

Applied to master with this little fix, thanks.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_LINUX_TOOLS
>  	select BR2_PACKAGE_LIBTRACEFS
>  	help
> @@ -123,6 +124,9 @@ config BR2_PACKAGE_LINUX_TOOLS_RTLA
>  	  not available in Buildroot, so only rtla in kernels 5.19
>  	  onwards is actually supported in Buildroot.
>  
> +comment "rtla needs a toolchain w/ dynamic library"
> +	depends on BR2_STATIC_LIBS
> +
>  config BR2_PACKAGE_LINUX_TOOLS_SELFTESTS
>  	bool"selftests"
>  	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot