From: Gary Bisson <bisson.gary@gmail.com>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: Refik Tuzakli <tuzakli.refik@gmail.com>,
Julien Olivain <ju.o@free.fr>, Fabio Estevam <festevam@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 2/3] package/freescale-imx/firmware-ele-imx: new package
Date: Mon, 22 Jan 2024 12:05:28 +0100 [thread overview]
Message-ID: <Za5L-Hg0l5wCdejw@p1g2> (raw)
In-Reply-To: <20240109172600.12811-3-sebastien.szymanski@armadeus.com>
Hi,
On Tue, Jan 09, 2024 at 06:25:59PM +0100, Sébastien Szymanski wrote:
> This package provides firmware blobs for the Edgelock Secure
> Enclave (ELE) [1] present on i.MX8ULP and i.MX9 Socs.
> This version comes from the 6.1.55-2.2.0 release.
>
> [1] https://www.nxp.com/products/nxp-product-information/nxp-product-programs/edgelock-secure-enclave:EDGELOCK-SECURE-ENCLAVE
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>
> Changes for v3:
> - rename package from firmware-sentinel to package firmware-ele-imx
>
> Changes for v2:
> - none
>
> package/freescale-imx/Config.in | 30 +++++++++++++++++++
> .../freescale-imx/firmware-ele-imx/Config.in | 21 +++++++++++++
> .../firmware-ele-imx/firmware-ele-imx.hash | 4 +++
> .../firmware-ele-imx/firmware-ele-imx.mk | 27 +++++++++++++++++
> 4 files changed, 82 insertions(+)
> create mode 100644 package/freescale-imx/firmware-ele-imx/Config.in
> create mode 100644 package/freescale-imx/firmware-ele-imx/firmware-ele-imx.hash
> create mode 100644 package/freescale-imx/firmware-ele-imx/firmware-ele-imx.mk
>
> diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in
> index 0229eaf0271f..da60d0879840 100644
> --- a/package/freescale-imx/Config.in
> +++ b/package/freescale-imx/Config.in
> @@ -69,6 +69,35 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93
>
> endchoice
>
> +choice
> + prompt "i.MX platform asic version"
Please rename "i.MX Silicon Revision" in order to match the Datasheet
naming (see 1.1 Ordering Information section).
> + default BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX91A1 \
> + if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX91
> + default BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93A1 \
> + if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX91 || \
> + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93
> + help
> + Some packages related to the selected i.MX platform need
> + to know the asic version of the platform they will run on.
> + If you don't know, leave the default value.
> +
> + Note - mismatches may result in a failure to boot!
> +
> +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX91A1
> + bool "imx91a1"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX91
> +
> +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93A0
> + bool "imx93a0"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93
> +
> +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93A1
> + bool "imx93a1"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93
> +
> +endchoice
> +
Actually, can you add that part above with the previous patch?
I believe this should be part of the overall CPU addition support.
> config BR2_PACKAGE_FREESCALE_IMX_PLATFORM
> string
> default "IMX25_3STACK" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX25_3STACK
> @@ -125,6 +154,7 @@ source "package/freescale-imx/imx-uuc/Config.in"
> source "package/freescale-imx/imx-vpu/Config.in"
> source "package/freescale-imx/imx-vpu-hantro/Config.in"
> source "package/freescale-imx/imx-vpuwrap/Config.in"
> +source "package/freescale-imx/firmware-ele-imx/Config.in"
> source "package/freescale-imx/firmware-imx/Config.in"
> source "package/freescale-imx/imx-sc-firmware/Config.in"
> source "package/freescale-imx/imx-seco/Config.in"
> diff --git a/package/freescale-imx/firmware-ele-imx/Config.in b/package/freescale-imx/firmware-ele-imx/Config.in
> new file mode 100644
> index 000000000000..7867c3712c9c
> --- /dev/null
> +++ b/package/freescale-imx/firmware-ele-imx/Config.in
> @@ -0,0 +1,21 @@
> +config BR2_PACKAGE_FIRMWARE_ELE_IMX
> + bool "firmware-ele-imx"
> + depends on BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX91 || \
> + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93
> + help
> + Firmware blobs for the Edgelock Secure Enclave (ELE)
> + present on i.MX8ULP and i.MX9 SoCs.
> +
> + This library is provided by NXP as-is and doesn't have an
> + upstream.
> +
> +if BR2_PACKAGE_FIRMWARE_ELE_IMX
> +
> +config BR2_PACKAGE_FIRMWARE_ELE_IMX_AHAB_CONTAINER_IMAGE
> + string
> + default "mx93a0-ahab-container.img" if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93A0
> + default "mx93a1-ahab-container.img" if \
> + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX91A1 || \
> + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX93A1
> +
> +endif # BR2_PACKAGE_FIRMWARE_ELE_IMX
> diff --git a/package/freescale-imx/firmware-ele-imx/firmware-ele-imx.hash b/package/freescale-imx/firmware-ele-imx/firmware-ele-imx.hash
> new file mode 100644
> index 000000000000..58565cef43e9
> --- /dev/null
> +++ b/package/freescale-imx/firmware-ele-imx/firmware-ele-imx.hash
> @@ -0,0 +1,4 @@
> +# Locally calculated
> +sha256 4a0440168d8dfb95989a17be8fafb149589e110e7d4518e5e8a33463dfb5e5ca firmware-ele-imx-0.1.0.bin
> +sha256 24d7cb3a7e51011466a149bd99acf89387b832be2d0890ce2e183dfbc9d7cb84 COPYING
> +sha256 c800aaca3a7e9f470d99d7cde0a48c95982ed601d4c306f7b8f43f3710054f28 SCR.txt
> diff --git a/package/freescale-imx/firmware-ele-imx/firmware-ele-imx.mk b/package/freescale-imx/firmware-ele-imx/firmware-ele-imx.mk
> new file mode 100644
> index 000000000000..600b50c5b456
> --- /dev/null
> +++ b/package/freescale-imx/firmware-ele-imx/firmware-ele-imx.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# firmware-ele-imx
> +#
> +################################################################################
> +
> +FIRMWARE_ELE_IMX_VERSION = 0.1.0
> +FIRMWARE_ELE_IMX_SITE = $(FREESCALE_IMX_SITE)
> +FIRMWARE_ELE_IMX_SOURCE = firmware-ele-imx-$(FIRMWARE_ELE_IMX_VERSION).bin
> +
> +FIRMWARE_ELE_IMX_LICENSE = NXP Semiconductor Software License Agreement
> +FIRMWARE_ELE_IMX_LICENSE_FILES = COPYING SCR.txt
> +FIRMWARE_ELE_IMX_REDISTRIBUTE = NO
> +
> +FIRMWARE_ELE_IMX_INSTALL_IMAGES = YES
> +
> +define FIRMWARE_ELE_IMX_EXTRACT_CMDS
> + $(call NXP_EXTRACT_HELPER,$(FIRMWARE_ELE_IMX_DL_DIR)/$(FIRMWARE_ELE_IMX_SOURCE))
> +endef
> +
> +FIRMWARE_ELE_IMX_AHAB_CONTAINER_IMAGE = $(call qstrip,$(BR2_PACKAGE_FIRMWARE_ELE_IMX_AHAB_CONTAINER_IMAGE))
> +
> +define FIRMWARE_ELE_IMX_INSTALL_IMAGES_CMDS
> + cp $(@D)/$(FIRMWARE_ELE_IMX_AHAB_CONTAINER_IMAGE) $(BINARIES_DIR)/ahab-container.img
> +endef
> +
> +$(eval $(generic-package))
The rest looks ok to me.
Thanks,
Gary
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-22 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 17:25 [Buildroot] [PATCH v3 0/3] i.MX91 and i.MX93 support Sébastien Szymanski
2024-01-09 17:25 ` [Buildroot] [PATCH v3 1/3] package/freescale-imx: add i.MX91 and i.MX93 SoC support Sébastien Szymanski
2024-01-22 11:01 ` Gary Bisson
2024-01-09 17:25 ` [Buildroot] [PATCH v3 2/3] package/freescale-imx/firmware-ele-imx: new package Sébastien Szymanski
2024-01-22 11:05 ` Gary Bisson [this message]
2024-01-09 17:26 ` [Buildroot] [PATCH v3 3/3] configs/freescale_imx93evk: new defconfig Sébastien Szymanski
2024-01-10 22:07 ` Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za5L-Hg0l5wCdejw@p1g2 \
--to=bisson.gary@gmail.com \
--cc=buildroot@buildroot.org \
--cc=festevam@gmail.com \
--cc=ju.o@free.fr \
--cc=sebastien.szymanski@armadeus.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tuzakli.refik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox